From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Wood <thomas.wood@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 2/3] lib: print the name of the currently running subtest
Date: Tue, 11 Mar 2014 21:11:07 +0100 [thread overview]
Message-ID: <20140311201107.GI30571@phenom.ffwll.local> (raw)
In-Reply-To: <1394554730-23229-3-git-send-email-thomas.wood@intel.com>
On Tue, Mar 11, 2014 at 04:18:49PM +0000, Thomas Wood wrote:
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> ---
> lib/drmtest.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 9f6e701..b8d3542 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -1007,6 +1007,9 @@ bool __igt_run_subtest(const char *subtest_name)
> return false;
> }
>
> + printf("Subtest %s: ", subtest_name);
> + fflush(stdout);
A lot of subtest spam stdout quite a bit, so we'd need to instaed print
start/stop markers - splitt up the lines like this will result in really
ugly output. See e.g. kms_flip.
-Daniel
> +
> return (in_subtest = subtest_name);
> }
>
> @@ -1028,7 +1031,7 @@ static int igt_exitcode;
> static void exit_subtest(const char *) __attribute__((noreturn));
> static void exit_subtest(const char *result)
> {
> - printf("Subtest %s: %s\n", in_subtest, result);
> + printf("%s\n", result);
> in_subtest = NULL;
> longjmp(igt_subtest_jmpbuf, 1);
> }
> --
> 1.8.5.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-03-11 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 16:18 [PATCH i-g-t 0/3] Various small changes Thomas Wood
2014-03-11 16:18 ` [PATCH i-g-t 1/3] tests: add missing assertion Thomas Wood
2014-03-11 16:18 ` [PATCH i-g-t 2/3] lib: print the name of the currently running subtest Thomas Wood
2014-03-11 20:11 ` Daniel Vetter [this message]
2014-03-11 16:18 ` [PATCH i-g-t 3/3] lib: Add missing header to Makefile.sources Thomas Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311201107.GI30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox