From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: Fix runtime pm inbalance due to reg I/O forcewake dance
Date: Fri, 14 Mar 2014 11:25:41 -0700 [thread overview]
Message-ID: <20140314112541.41195c3f@jbarnes-desktop> (raw)
In-Reply-To: <CAKMK7uEVxa+QnOOGgyn0szL4gf2-_AKO-LywVKBn1ByYya=ZPw@mail.gmail.com>
On Fri, 14 Mar 2014 09:52:47 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> On Fri, Mar 14, 2014 at 9:34 AM, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> >> Heh, I went the other way round, dropped the runtime pm put from the
> >> timer and flushed the forcewaker timer when we suspended the device...
> >
> > That's what I meant. No delayed runtime_pm_put.
>
> Well I've figured we want to keep this ... have things changed
> sufficiently meanwhile? I've lost a bit track in all that recent
> shuffling ...
Can we pull the forcewake bits out of the reg functions and just do a
check and WARN instead?
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-03-14 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 7:48 [PATCH] drm/i915: Fix runtime pm inbalance due to reg I/O forcewake dance Daniel Vetter
2014-03-14 8:18 ` Ville Syrjälä
2014-03-14 8:24 ` Chris Wilson
2014-03-14 8:34 ` Ville Syrjälä
2014-03-14 8:52 ` Daniel Vetter
2014-03-14 18:25 ` Jesse Barnes [this message]
2014-03-14 8:37 ` [PATCH] drm/i915: Rebalance runtime pm vs forcewake Chris Wilson
2014-03-14 15:51 ` Daniel Vetter
2014-03-14 16:13 ` Chris Wilson
2014-03-14 18:43 ` Daniel Vetter
2014-03-31 18:22 ` Paulo Zanoni
2014-03-31 18:59 ` Daniel Vetter
2014-04-01 8:14 ` Chris Wilson
2014-04-01 12:32 ` Paulo Zanoni
2014-04-01 12:42 ` Chris Wilson
2014-04-01 17:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314112541.41195c3f@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox