Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff McGee <jeff.mcgee@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] tests/pm_rps: load harder
Date: Fri, 14 Mar 2014 09:41:13 -0500	[thread overview]
Message-ID: <20140314144112.GC5686@jeffdesk> (raw)
In-Reply-To: <1394789268-28703-3-git-send-email-daniel.vetter@ffwll.ch>

On Fri, Mar 14, 2014 at 10:27:48AM +0100, Daniel Vetter wrote:
> Big core platforms need some seriuos omph to break a sweat.
> 
> This fixes min-max-config-loaded here on my ivb.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75146
> Cc: Jeff McGee <jeff.mcgee@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  tests/pm_rps.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tests/pm_rps.c b/tests/pm_rps.c
> index fc6bac647f4a..b5dd494443ff 100644
> --- a/tests/pm_rps.c
> +++ b/tests/pm_rps.c
> @@ -156,6 +156,7 @@ static struct load_helper {
>  	enum load load;
>  	bool exit;
>  	struct igt_helper_process igt_proc;
> +	drm_intel_bo *src, *dst;
>  } lh;
>  
>  static void load_helper_signal_handler(int sig)
> @@ -195,6 +196,7 @@ static void emit_store_dword_imm(uint32_t val)
>  }
>  
>  #define LOAD_HELPER_PAUSE_USEC 500
> +#define LOAD_HELPER_BO_SIZE (16*1024*1024)
>  static void load_helper_set_load(enum load load)
>  {
>  	assert(lh.igt_proc.running);
> @@ -226,6 +228,10 @@ static void load_helper_run(enum load load)
>  		signal(SIGUSR2, load_helper_signal_handler);
>  
>  		while (!lh.exit) {
> +			if (lh.load == HIGH)
> +				intel_copy_bo(lh.batch, lh.dst, lh.dst,
> +					      LOAD_HELPER_BO_SIZE);
> +
Did you mean to use lh.src here?
>  			emit_store_dword_imm(val);
>  			intel_batchbuffer_flush_on_ring(lh.batch, 0);
>  			val++;
> @@ -270,6 +276,13 @@ static void load_helper_init(void)
>  	lh.target_buffer = drm_intel_bo_alloc(lh.bufmgr, "target bo",
>  					      4096, 4096);
>  	igt_assert(lh.target_buffer);
> +
> +	lh.dst = drm_intel_bo_alloc(lh.bufmgr, "dst bo",
> +				    LOAD_HELPER_BO_SIZE, 4096);
> +	igt_assert(lh.dst);
> +	lh.src = drm_intel_bo_alloc(lh.bufmgr, "src bo",
> +				    LOAD_HELPER_BO_SIZE, 4096);
> +	igt_assert(lh.src);
>  }
>  
>  static void load_helper_deinit(void)
Should we free these in load_helper_deinit?
> -- 
> 1.8.4.rc3
> 

  reply	other threads:[~2014-03-14 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  9:27 [PATCH 1/3] tests/pm_rps: ducttape for igt fork helper cleanup issues Daniel Vetter
2014-03-14  9:27 ` [PATCH 2/3] tests/pm_rps: simplify load helper setup Daniel Vetter
2014-03-14 14:34   ` Jeff McGee
2014-03-14 15:31     ` Daniel Vetter
2014-03-14  9:27 ` [PATCH 3/3] tests/pm_rps: load harder Daniel Vetter
2014-03-14 14:41   ` Jeff McGee [this message]
2014-03-14 15:47     ` Daniel Vetter
2014-03-14 14:29 ` [PATCH 1/3] tests/pm_rps: ducttape for igt fork helper cleanup issues Jeff McGee
2014-03-14 15:34   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140314144112.GC5686@jeffdesk \
    --to=jeff.mcgee@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox