From: Daniel Vetter <daniel@ffwll.ch>
To: "Volkin, Bradley D" <bradley.d.volkin@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use the correct format string modifier for ptrdiff_t
Date: Tue, 18 Mar 2014 19:58:59 +0100 [thread overview]
Message-ID: <20140318185859.GI30571@phenom.ffwll.local> (raw)
In-Reply-To: <20140318175301.GA31425@bdvolkin-ubuntu-desktop>
On Tue, Mar 18, 2014 at 10:53:01AM -0700, Volkin, Bradley D wrote:
> Thanks for fixing this Damien.
>
> Reviewed-by: Brad Volkin <bradley.d.volkin@intel.com>
>
> On Tue, Mar 18, 2014 at 05:43:08PM +0000, Damien Lespiau wrote:
> > When compiling on 32bits, I have the following warning:
> >
> > drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format ‘%ld’
> > expects argument of type ‘long int’, but argument 7 has type ‘int’
> > [-Wformat=]
> > DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X
> > length=%d batchlen=%ld\n",
> >
> > The ptrdiff_t type has its own modifier: 't'.
> >
> > Cc: Brad Volkin <bradley.d.volkin@intel.com>
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> > ---
> > drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c
> > index 7a5756e..0eaed44 100644
> > --- a/drivers/gpu/drm/i915/i915_cmd_parser.c
> > +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c
> > @@ -402,7 +402,7 @@ int i915_parse_cmds(struct intel_ring_buffer *ring,
> > length = ((*cmd & desc->length.mask) + LENGTH_BIAS);
> >
> > if ((batch_end - cmd) < length) {
> > - DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X length=%d batchlen=%ld\n",
> > + DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X length=%d batchlen=%td\n",
> > *cmd,
> > length,
> > batch_end - cmd);
> > --
> > 1.8.3.1
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-03-18 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 17:43 [PATCH] drm/i915: Use the correct format string modifier for ptrdiff_t Damien Lespiau
2014-03-18 17:53 ` Volkin, Bradley D
2014-03-18 18:58 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318185859.GI30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=bradley.d.volkin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox