Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <benjamin.widawsky@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Allow full PPGTT with param override
Date: Tue, 25 Mar 2014 10:46:12 +0100	[thread overview]
Message-ID: <20140325094612.GP26878@phenom.ffwll.local> (raw)
In-Reply-To: <1395709560-19686-1-git-send-email-benjamin.widawsky@linux.intel.com>

On Mon, Mar 24, 2014 at 06:06:00PM -0700, Ben Widawsky wrote:
> When PPGTT was disabled by default, the patch also prevented the user
> from overriding this behavior via module parameter. Being able to test
> this on arbitrary kernels is extremely beneficial to track down the
> remaining bugs. The patch that prevented this was:
> 
> commit 93a25a9e2d67765c3092bfaac9b855d95e39df97
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Thu Mar 6 09:40:43 2014 +0100
> 
>     drm/i915: Disable full ppgtt by default
> 
> By default PPGTT is set to -1. 0 means off, 1 means aliasing only, 2
> means full, all other values are reserved.
> 
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

My apologies for breaking this a bit harder than intended, and thanks for
fixing it up. Patch merged to dinq.
-Daniel

> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index bbc9420..9068628 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -50,7 +50,7 @@ bool intel_enable_ppgtt(struct drm_device *dev, bool full)
>  
>  	/* Full ppgtt disabled by default for now due to issues. */
>  	if (full)
> -		return false; /* HAS_PPGTT(dev) */
> +		return HAS_PPGTT(dev) && (i915.enable_ppgtt == 2);
>  	else
>  		return HAS_ALIASING_PPGTT(dev);
>  }
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-03-25  9:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25  1:06 [PATCH] drm/i915: Allow full PPGTT with param override Ben Widawsky
2014-03-25  9:46 ` Daniel Vetter [this message]
2014-03-25 16:42   ` Ben Widawsky
2014-03-25 16:49     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140325094612.GP26878@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=benjamin.widawsky@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox