Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: vlv: fix RPS interrupt mask setting
Date: Thu, 3 Apr 2014 21:28:34 +0100	[thread overview]
Message-ID: <20140403202834.GA21064@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1396544562-5024-1-git-send-email-imre.deak@intel.com>

On Thu, Apr 03, 2014 at 08:02:42PM +0300, Imre Deak wrote:
> This typo may lead to missed RPS interrupts and as a result a too
> low or too high frequency for the current workload. The interrupt mask
> will be set properly at a subsequent GPU idle event, but can get
> corrupted again at the next RPS up/down event.
> 
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Embarrassing. Really odd as I thought I just cut'n'paste that line.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2014-04-03 20:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 17:02 [PATCH] drm/i915: vlv: fix RPS interrupt mask setting Imre Deak
2014-04-03 20:28 ` Chris Wilson [this message]
2014-04-03 21:10   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403202834.GA21064@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox