Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Volkin, Bradley D" <bradley.d.volkin@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] tests/gem_exec_parse: Test for OACONTROL tracking
Date: Wed, 9 Apr 2014 14:25:09 +0200	[thread overview]
Message-ID: <20140409122509.GH9262@phenom.ffwll.local> (raw)
In-Reply-To: <20140408212858.GA6764@bdvolkin-ubuntu-desktop>

On Tue, Apr 08, 2014 at 02:28:58PM -0700, Volkin, Bradley D wrote:
> Hi Daniel, we've merged the kernel change for this but not the test. I'm
> assuming we still want the test case.

Sorry this fell through the cracks - pretty much everyone on our team has
igt access so we just push igt patches and tests after a bit of soaking
time on intel-gfx.

It might be good to designate a point person for all things igt on the vpg
side (Tim Gore maybe) who has push access and could take care of such
things. Adding Tim.
-Daniel

> 
> Brad
> 
> On Thu, Mar 27, 2014 at 11:44:45AM -0700, Volkin, Bradley D wrote:
> > From: Brad Volkin <bradley.d.volkin@intel.com>
> > 
> > Signed-off-by: Brad Volkin <bradley.d.volkin@intel.com>
> > ---
> >  tests/gem_exec_parse.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 48 insertions(+)
> > 
> > diff --git a/tests/gem_exec_parse.c b/tests/gem_exec_parse.c
> > index 34d097d..853eb57 100644
> > --- a/tests/gem_exec_parse.c
> > +++ b/tests/gem_exec_parse.c
> > @@ -204,6 +204,8 @@ int fd;
> >  #define   PIPE_CONTROL_QW_WRITE	(1<<14)
> >  #define   PIPE_CONTROL_LRI_POST_OP (1<<23)
> >  
> > +#define OACONTROL 0x2360
> > +
> >  igt_main
> >  {
> >  	igt_fixture {
> > @@ -337,6 +339,52 @@ igt_main
> >  					    0));
> >  	}
> >  
> > +	igt_subtest("oacontrol-tracking") {
> > +		uint32_t lri_ok[] = {
> > +			MI_LOAD_REGISTER_IMM,
> > +			OACONTROL,
> > +			0x31337000,
> > +			MI_LOAD_REGISTER_IMM,
> > +			OACONTROL,
> > +			0x0,
> > +			MI_BATCH_BUFFER_END,
> > +			0
> > +		};
> > +		uint32_t lri_bad[] = {
> > +			MI_LOAD_REGISTER_IMM,
> > +			OACONTROL,
> > +			0x31337000,
> > +			MI_BATCH_BUFFER_END,
> > +		};
> > +		uint32_t lri_extra_bad[] = {
> > +			MI_LOAD_REGISTER_IMM,
> > +			OACONTROL,
> > +			0x31337000,
> > +			MI_LOAD_REGISTER_IMM,
> > +			OACONTROL,
> > +			0x0,
> > +			MI_LOAD_REGISTER_IMM,
> > +			OACONTROL,
> > +			0x31337000,
> > +			MI_BATCH_BUFFER_END,
> > +		};
> > +		igt_assert(
> > +			exec_batch(fd, handle,
> > +				      lri_ok, sizeof(lri_ok),
> > +				      I915_EXEC_RENDER,
> > +				      0));
> > +		igt_assert(
> > +			exec_batch(fd, handle,
> > +				      lri_bad, sizeof(lri_bad),
> > +				      I915_EXEC_RENDER,
> > +				      -EINVAL));
> > +		igt_assert(
> > +			exec_batch(fd, handle,
> > +				      lri_extra_bad, sizeof(lri_extra_bad),
> > +				      I915_EXEC_RENDER,
> > +				      -EINVAL));
> > +	}
> > +
> >  	igt_fixture {
> >  		gem_close(fd, handle);
> >  
> > -- 
> > 1.8.3.2
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply	other threads:[~2014-04-09 12:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 18:44 [PATCH] tests/gem_exec_parse: Test for OACONTROL tracking bradley.d.volkin
2014-04-08 21:28 ` Volkin, Bradley D
2014-04-09 12:25   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140409122509.GH9262@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=bradley.d.volkin@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox