From: Ben Widawsky <ben@bwidawsk.net>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Ben Widawsky" <benjamin.widawsky@intel.com>,
"Intel GFX" <intel-gfx@lists.freedesktop.org>,
"Art Runyan" <arthur.j.runyan@intel.com>
Subject: Re: [PATCH] drm/i915/bdw: Don't allow the FBC base to be 0
Date: Fri, 2 May 2014 18:48:52 -0700 [thread overview]
Message-ID: <20140503014851.GA22130@bwidawsk.net> (raw)
In-Reply-To: <20140502203520.GA9420@nuc-i3427.alporthouse.com>
On Fri, May 02, 2014 at 09:35:20PM +0100, Chris Wilson wrote:
> On Fri, May 02, 2014 at 10:00:01AM -0700, Ben Widawsky wrote:
> > On Fri, May 02, 2014 at 04:00:25PM +0300, Ville Syrjälä wrote:
> > > On Fri, May 02, 2014 at 09:38:11AM +0100, Chris Wilson wrote:
> > > > On Fri, May 02, 2014 at 11:19:27AM +0300, Ville Syrjälä wrote:
> > > > > On Thu, May 01, 2014 at 06:47:54PM -0700, Ben Widawsky wrote:
> > > > > > "Restriction :
> > > > > > The offset must be greater than 4K bytes, avoiding the first 4KB of
> > > > > > stolen memory."
> > > > >
> > > > > Isn't this a more generic issue that we must avoid the first 4k? If so
> > > > > I think we should just reserve the first 4k permanently at driver init
> > > > > time.
> >
> > Is anyone opposed to this plan? Realistically it won't make a
> > difference.
> >
> > > >
> > > > What? On many machines the vga framebuffer is allocated from offset 0. I
> > > > think some explanation is in order.
> >
> > The chopped off part of the commit message explained it (if I understood
> > your point).
>
> How do we handle the inherited fb if it starts at offset 0?
> -Chris
>
I must be missing something important. The FBC buffer is the only one
requiring a non-zero offset from the base of stolen memory.
--
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-05-03 1:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 1:47 [PATCH] drm/i915/bdw: Don't allow the FBC base to be 0 Ben Widawsky
2014-05-02 8:19 ` Ville Syrjälä
2014-05-02 8:38 ` Chris Wilson
2014-05-02 13:00 ` Ville Syrjälä
2014-05-02 17:00 ` Ben Widawsky
2014-05-02 20:35 ` Chris Wilson
2014-05-03 1:48 ` Ben Widawsky [this message]
2014-05-15 14:05 ` Ville Syrjälä
2014-05-15 14:45 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140503014851.GA22130@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=arthur.j.runyan@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox