public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Akash Goel <akash.goel@intel.com>
Cc: intel-gfx@lists.freedesktop.org, sourab.gupta@intel.com
Subject: Re: [RFC] drm/i915: Scratch page optimization for blanking buffer
Date: Wed, 7 May 2014 09:39:10 +0200	[thread overview]
Message-ID: <20140507073910.GK5730@phenom.ffwll.local> (raw)
In-Reply-To: <1399441797.12368.6.camel@akashgoe-desktop>

On Wed, May 07, 2014 at 11:19:57AM +0530, Akash Goel wrote:
> On Mon, 2014-05-05 at 16:07 +0200, Daniel Vetter wrote:
> > On Mon, May 05, 2014 at 05:13:18PM +0530, akash.goel@intel.com wrote:
> > > From: Akash Goel <akash.goel@intel.com>
> > > 
> > > There is a use case, when user space (display compositor) tries
> > > to directly flip a fb (without any prior rendering) on primary
> > > plane. So the backing pages of the object are allocated at page
> > > flip time only, which takes time. Since, this buffer is supposed to
> > > serve as a blanking buffer (black colored), we can setup all the GTT entries
> > > of that blanking buffer with scratch page (which is already zeroed out).
> > > This saves the time in allocation of real backing physical space for the
> > > blanking buffer and flushing of CPU cache.
> > > 
> > > Signed-off-by: Akash Goel <akash.goel@intel.com>
> > 
> > That sounds very much like a special case of the fallocate ioctl where we
> > simply allocat 0 real backing storage pages.
> > -Daniel
> > 
> 
> Hi Daniel,
> 
> Yes no real backing storage is needed, but still the object should be
> allowed to get mapped into the GGTT, using the scratch page (already
> zeroed out).
> 
> Is there a patch for a new drm/i915 ioctl similar to fallocate, which
> could be used here?

Geez, you guys shouldn't just dump patches onto intel-gfx but read a bit
what other people are doing. Especially when they work for the same team
;-)

http://comments.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/36351

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2014-05-07  7:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05 11:43 [RFC] drm/i915: Scratch page optimization for blanking buffer akash.goel
2014-05-05 11:47 ` Chris Wilson
2014-05-05 12:33   ` Akash Goel
2014-05-05 12:39     ` Chris Wilson
2014-05-05 12:53       ` Akash Goel
2014-05-05 14:07 ` Daniel Vetter
2014-05-07  5:49   ` Akash Goel
2014-05-07  7:39     ` Daniel Vetter [this message]
2014-05-07 10:54       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507073910.GK5730@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=akash.goel@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sourab.gupta@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox