From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Drop unused lut tables from intel_plane
Date: Tue, 3 Jun 2014 09:48:59 +0200 [thread overview]
Message-ID: <20140603074859.GK19050@phenom.ffwll.local> (raw)
In-Reply-To: <20140602180652.GA32209@strange.amr.corp.intel.com>
On Mon, Jun 02, 2014 at 07:06:52PM +0100, Damien Lespiau wrote:
> On Mon, Jun 02, 2014 at 10:12:06AM -0700, Matt Roper wrote:
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>
> The commit message is a bit terse and could do with some digging.
> Something like:
>
> Those LUT where defined in the original sprite patch introducing intel_plane,
> but were never used.
>
> commit b840d907fcf6d5d5ef91af4518b3dab3a5da0f75
> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date: Tue Dec 13 13:19:38 2011 -0800
>
> drm/i915: add SNB and IVB video sprite support v6
Added.
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/intel_drv.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> > index 76de420..fea8e05 100644
> > --- a/drivers/gpu/drm/i915/intel_drv.h
> > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > @@ -428,7 +428,6 @@ struct intel_plane {
> > struct drm_i915_gem_object *obj;
> > bool can_scale;
> > int max_downscale;
> > - u32 lut_r[1024], lut_g[1024], lut_b[1024];
> > int crtc_x, crtc_y;
> > unsigned int crtc_w, crtc_h;
> > uint32_t src_x, src_y;
> > --
> > 1.8.5.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-06-03 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 17:12 [PATCH] drm/i915: Drop unused lut tables from intel_plane Matt Roper
2014-06-02 18:06 ` Damien Lespiau
2014-06-03 7:48 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603074859.GK19050@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox