Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: PM irq enabling is generic on gen8, too
Date: Tue, 15 Jul 2014 08:26:04 +0100	[thread overview]
Message-ID: <20140715072604.GB4919@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1405408661-7915-1-git-send-email-daniel.vetter@ffwll.ch>

On Tue, Jul 15, 2014 at 09:17:41AM +0200, Daniel Vetter wrote:
> From: Damien Lespiau <damien.lespiau@intel.com>
> 
> No need to list all the platforms explicitly.
> 
> The prefix is a bit inconsistent since we usually pick gen8_ for GT
> related functions. But this anti-pattern is already established with snb,
> so material for a different patch.
> 
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

-- 
Damien

> ---
>  drivers/gpu/drm/i915/i915_irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index c03367af7a8e..e12dfdf4b720 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1403,7 +1403,7 @@ static void gen6_pm_rps_work(struct work_struct *work)
>  	spin_lock_irq(&dev_priv->irq_lock);
>  	pm_iir = dev_priv->rps.pm_iir;
>  	dev_priv->rps.pm_iir = 0;
> -	if (IS_BROADWELL(dev_priv->dev) || IS_CHERRYVIEW(dev_priv->dev))
> +	if (INTEL_INFO(dev_priv->dev)->gen >= 8)
>  		bdw_enable_pm_irq(dev_priv, dev_priv->pm_rps_events);
>  	else {
>  		/* Make sure not to corrupt PMIMR state used by ringbuffer */
> -- 
> 1.9.3
> 

  parent reply	other threads:[~2014-07-15  7:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15  7:17 [PATCH] drm/i915: PM irq enabling is generic on gen8, too Daniel Vetter
2014-07-15  7:21 ` [PATCH] drm/i915: Also give the sprite width for WM computation Daniel Vetter
2014-07-15  7:26 ` Damien Lespiau [this message]
2014-07-15  8:11   ` [PATCH] drm/i915: PM irq enabling is generic on gen8, too Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140715072604.GB4919@strange.ger.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox