From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Don't require dev->struct_mutex in psr_match_conditions
Date: Mon, 4 Aug 2014 17:01:05 +0200 [thread overview]
Message-ID: <20140804150105.GY8727@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGRhrSGf_oqcJqVAfmgPkkBEqv---ePJobTbf=p4hnyQvA@mail.gmail.com>
On Mon, Aug 04, 2014 at 11:16:10AM -0300, Paulo Zanoni wrote:
> 2014-08-04 5:46 GMT-03:00 Daniel Vetter <daniel.vetter@ffwll.ch>:
> > Since I've reworked psr support to no longer require x-tiling we don't
> > check any state protected by the Giant GEM Lock. So drop that check.
> >
> > Also boo for lockdep_assert_held for not yelling when lockdep is
> > disabled.
> >
> > Cc: Paulo Zanoni <przanoni@gmail.com>
> > Reported-by: Paulo Zanoni <przanoni@gmail.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> I was going to start reviewing it, but then I realized it's already merged.
Oh, I've figured I'll sneak this one by the "danvet must have reviewed-by
too" rule ;-) But I'll drop such patches asap if anyone spots something
with them ofc.
> Do we have any doc explaining all our locks/mutexes and what each one
> is supposed to protect?
Unfortunately not. It's also constantly changing (e.g. the recent
introduction of the connection_mutex) and rather shockingly often not
quite correct. Atm you need to dig through git history and for drm core
locks through all drm drivers to figure this out :(
> Anyway, the patch looks fine.
I'll count this as an ack and added it, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-08-04 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 18:49 [PATCH] drm/i915: grab struct_mutex at intel_edp_psr_enable() Paulo Zanoni
2014-08-04 8:46 ` [PATCH] drm/i915: Don't require dev->struct_mutex in psr_match_conditions Daniel Vetter
2014-08-04 14:16 ` Paulo Zanoni
2014-08-04 15:01 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804150105.GY8727@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox