Re: [PATCH] drm/i915: Fix secure dispatch with full ppgtt

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Aug 11, 2014 at 11:17:40AM +0100, Chris Wilson wrote:
> On Mon, Aug 11, 2014 at 12:08:58PM +0200, Daniel Vetter wrote:
> > Based upon a hunk from a patch from Chris Wilson, but augmented to:
> > - Process the batch in the full ppgtt vm so that self-relocations
> >   match again with userspace's expectations..
> > - Add a comment why plain pin for the global gtt binding is safe at
> >   that point.
> > 
> > v2: Drop local bind_vm variable (Chris).
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> /me jaw drops
> 
> Oh nice, yes you are right that does fix the issue with the relocations
> being in one address space whilst the exec needs to be done from gGTT.
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Actually it's not that simple - with this patch we don't add the ggtt vma
for the batch to the active list, which we probably should. So needs to be
revised a bit more I think ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch