From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 09/12] tests/kms_psr_sink_crc: Fix all testcases.
Date: Fri, 5 Sep 2014 10:32:26 +0200 [thread overview]
Message-ID: <20140905083226.GD15520@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+tj-KEC_s7aemdYS_Uj-d74BFggtUGA+Gr91nNNvhAVHg@mail.gmail.com>
On Thu, Sep 04, 2014 at 05:55:24PM -0700, Rodrigo Vivi wrote:
> adding suspend_autoresume on primary tests like this:
> @ -470,6 +472,8 @@ igt_main
> data.test_plane = PRIMARY;
> data.op = op;
> run_test(&data);
> + igt_system_suspend_autoresume();
> + run_test(&data);
>
> on BDW I got these results:
>
>
> vivijim rdvivi-seattle tests$ sudo ./kms_psr_sink_crc
> IGT-Version: 1.7-gd4b43f0 (x86_64) (Linux: 3.17.0-rc2+ x86_64)
> rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Sep 5 00:44:03 2014
> Subtest primary_page_flip: SUCCESS
> rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Sep 5 00:44:40 2014
> Subtest primary_mmap_gtt: SUCCESS
> Waiting 10s...
> rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Sep 5 00:45:27 2014
> Waiting 10s...
> Subtest primary_mmap_gtt_waiting: SUCCESS
> rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Sep 5 00:46:13 2014
> Subtest primary_mmap_cpu: SUCCESS
> rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Sep 5 00:46:50 2014
> Subtest primary_blt: SUCCESS
> rtcwake: wakeup from "mem" using /dev/rtc0 at Fri Sep 5 00:47:27 2014
> Subtest primary_render: SUCCESS
>
> on HSW I couldn't test because suspend/resume breaks even with psr disabled.
> I'm going to check more tomorrow..
>
> But regarding the suspend resume test, how do you suggest to organize it?
> Extra loops for all current cases?
> suspend_{primary, sprite, cursor}_{page_flip, mmap_gtt, etc}? I believe the
> test will take so long to finish on this case what is bad for qa alghouth
> it is the complete one. What do you think?
I think we don't need the full set of tests also with system suspend. I
think just one test which catches the current bug is good enough, after
all if psr is set up correctly it should work the same at runtime than
over s/r. And since this is a test I'd just copypaste the relevant subtest
(if it doesn't integrate quickly into the existing code), not worth at all
to make a big fuzz.
And we have lots of resume tests already, they "only" take about
30 second. Only important to have "suspend" somewhere in the subtest name
so that all system suspend tests can easily be filtered out/selected.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-09-05 8:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 1:29 [PATCH 01/12] tests/pm_psr: Update pm_psr for new psr debug interface Rodrigo Vivi
2014-09-04 1:29 ` [PATCH 02/12] tests/kms_sink_crc_basic: Use igt_debugfs_fopen Rodrigo Vivi
2014-09-04 1:29 ` [PATCH 03/12] tests/kms_sink_crc_basic: Simplify test by using igt_kms functions Rodrigo Vivi
2014-09-09 23:09 ` [PATCH] " Rodrigo Vivi
2014-09-09 23:09 ` [PATCH] tests/kms_sink_crc_basic: Wait 2 vblanks before grabing the new crc Rodrigo Vivi
2014-09-04 1:29 ` [PATCH 04/12] tests/kms_psr_sink_crc: Fix edp_psr debugfs interface Rodrigo Vivi
2014-09-04 1:29 ` [PATCH 05/12] tests/kms_psr_sink_crc: Adding test debug options Rodrigo Vivi
2014-09-04 1:30 ` [PATCH 06/12] tests/kms_psr_sink_crc: Removing context tests Rodrigo Vivi
2014-09-04 1:30 ` [PATCH 07/12] tests/kms_psr_sink_crc: Cleaning up tests a bit Rodrigo Vivi
2014-09-04 1:30 ` [PATCH 08/12] tests/kms_psr_sink_crc: Start splitting tests in test_planes and operations Rodrigo Vivi
2014-09-04 1:30 ` [PATCH 09/12] tests/kms_psr_sink_crc: Fix all testcases Rodrigo Vivi
[not found] ` <20140904090413.GC15520@phenom.ffwll.local>
2014-09-04 20:24 ` Rodrigo Vivi
2014-09-05 0:55 ` Rodrigo Vivi
2014-09-05 8:32 ` Daniel Vetter [this message]
2014-09-04 1:30 ` [PATCH 10/12] tests/kms_psr_sink_crc: Check color ref CRC Rodrigo Vivi
2014-09-04 1:30 ` [PATCH 11/12] tests/kms_psr_sink_crc: Fix blt submission Rodrigo Vivi
2014-09-04 1:30 ` [PATCH 12/12] tests/kms_psr_sink_crc: Wait 2 vblanks before grabing the new crc Rodrigo Vivi
[not found] ` <20140904084707.GA15520@phenom.ffwll.local>
2014-09-04 20:03 ` [PATCH 01/12] tests/pm_psr: Update pm_psr for new psr debug interface Rodrigo Vivi
2014-09-09 23:12 ` [PATCH] tests: Kill pm_psr Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140905083226.GD15520@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox