From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: Avoid reading fbc registers in vain when fbc was never enabled.
Date: Fri, 19 Sep 2014 17:40:07 +0200 [thread overview]
Message-ID: <20140919154007.GF15734@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+s8fCFfESJzR8v63ukgbCKf+w=__=YWHyREBy75vxkh9Q@mail.gmail.com>
On Thu, Sep 18, 2014 at 11:42:44AM -0700, Rodrigo Vivi wrote:
> On Thu, Sep 18, 2014 at 4:39 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
>
> > On Thu, Sep 18, 2014 at 07:28:48AM +0100, Chris Wilson wrote:
> > > On Wed, Sep 17, 2014 at 04:59:20PM -0400, Rodrigo Vivi wrote:
> > > > If it wasn't never enabled by kernel parameter or platform default
> > > > we can avoid reading registers so many times in vain
> > >
> > > Nak.
> >
> > Well I've merged this for now to reduce fbc impact.
> >
>
> Uhm, unfortunatelly I'm afraid Chris was right.
> Paulo also nacked it. Because it just helps when it was explicitly disabled
> by setting i915.enable_fbc=0 while the default is -1.
>
> I though about returning on <= 0, but Paulo is afraid that when enabling
> back for some platform people would forget to fix this part here and I
> agree.
Well I guess I should have read mails before pushing out a new -next ;-)
So this is now baked in. Should I revert or can we just fix up on top?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-09-19 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 20:59 [PATCH] drm/i915: Avoid reading fbc registers in vain when fbc was never enabled Rodrigo Vivi
2014-09-18 6:28 ` Chris Wilson
2014-09-18 11:39 ` Daniel Vetter
2014-09-18 18:42 ` Rodrigo Vivi
2014-09-18 22:37 ` Paulo Zanoni
2014-09-19 15:40 ` Daniel Vetter [this message]
2014-09-19 18:24 ` Rodrigo Vivi
2014-09-19 18:29 ` Paulo Zanoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919154007.GF15734@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@gmail.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox