From: Daniel Vetter <daniel@ffwll.ch>
To: "Cheng, Yao" <yao.cheng@intel.com>
Cc: "Rao, Ram R" <ram.r.rao@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Jiang, Fei" <fei.jiang@intel.com>,
"Abel, Michael J" <michael.j.abel@intel.com>,
"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [Intel-gfx] [RFC PATCH v2 1/4] drm/i915: add i915_ved.c to setup bridge for VED
Date: Wed, 22 Oct 2014 10:43:59 +0200 [thread overview]
Message-ID: <20141022084359.GO26941@phenom.ffwll.local> (raw)
In-Reply-To: <8FF7D634BEE4C2428EFFAB6B7E919E4B017D968D@shsmsx102.ccr.corp.intel.com>
On Wed, Oct 22, 2014 at 07:11:21AM +0000, Cheng, Yao wrote:
> > -----Original Message-----
> > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel
> > Vetter
> > Sent: Tuesday, October 21, 2014 8:09 PM
> > To: Cheng, Yao
> > Cc: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Kelley,
> > Sean V; Vetter, Daniel; Abel, Michael J; Jiang, Fei; Rao, Ram R
> > Subject: Re: [Intel-gfx] [RFC PATCH v2 1/4] drm/i915: add i915_ved.c to setup
> > bridge for VED
> >
> > On Tue, Oct 21, 2014 at 02:36:41PM +0800, Yao Cheng wrote:
> > > Setup minimum required resources during i915_driver_load:
> > > 1. Create a platform device to share MMIO/IRQ resources 2. Make the
> > > platform device child of i915 device for runtime PM.
> > > 3. Create IRQ chip to forward the VED irqs.
> > > VED driver (a standalone drm driver) probes the VED device and creates
> > > a new dri card on install.
> > >
> > > Currently only supports VED on valleyview.
> > > Kerneldoc is updated for i915_ved.c.
> > >
> > > Signed-off-by: Yao Cheng <yao.cheng@intel.com>
> >
> > Please resend with a patch changelog to account for my review comments.
> > And Ville's. Plus cc us both. And if there's anything you didn't address, you
> > must reply to the review and we need to further discuss this.
> >
>
> Daniel, I see, thanks for the instruction.
> Do you mean resending the [RFC PATCH v2] with changelog and cc list?
> Or adding changelog/cc when sending [RFC PATCH v3]?
I think you could just add the per-patch changelog for both v2 and v3 when
sending out v3.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-10-22 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 6:36 [RFC PATCH v2 0/4] drm driver for VED in Intel GPU Yao Cheng
2014-10-21 6:36 ` [RFC PATCH v2 1/4] drm/i915: add i915_ved.c to setup bridge for VED Yao Cheng
2014-10-21 10:29 ` Ville Syrjälä
2014-10-22 7:09 ` Cheng, Yao
2014-10-22 7:49 ` Ville Syrjälä
2014-10-23 14:38 ` [Intel-gfx] " Cheng, Yao
2014-10-21 12:09 ` Daniel Vetter
2014-10-22 7:11 ` Cheng, Yao
2014-10-22 8:43 ` Daniel Vetter [this message]
2014-10-23 6:50 ` [Intel-gfx] " Cheng, Yao
2014-10-21 6:36 ` [RFC PATCH v2 2/4] drm/ipvr: drm driver " Yao Cheng
2014-10-21 9:08 ` Daniel Vetter
2014-10-22 6:37 ` Cheng, Yao
2014-10-22 8:50 ` Daniel Vetter
2014-10-23 6:59 ` Cheng, Yao
2014-10-23 14:45 ` [Intel-gfx] " Cheng, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022084359.GO26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fei.jiang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michael.j.abel@intel.com \
--cc=ram.r.rao@intel.com \
--cc=yao.cheng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox