From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Stone <daniel@fooishbar.org>
Cc: "Vetter, Daniel" <daniel.vetter@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
Emil Velikov <emil.l.velikov@gmail.com>,
"Jiang, Fei" <fei.jiang@intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver
Date: Wed, 29 Oct 2014 09:14:52 +0100 [thread overview]
Message-ID: <20141029081452.GO26941@phenom.ffwll.local> (raw)
In-Reply-To: <CAPj87rMWHTHC=kSHuSe7cL7jRkBDU85tYSLK9HvRy9qSO16MwQ@mail.gmail.com>
On Tue, Oct 28, 2014 at 04:56:03PM +0000, Daniel Stone wrote:
> Hi,
>
> On 17 October 2014 01:36, Jiang, Fei <fei.jiang@intel.com> wrote:
>
> > Thanks for Emil's suggestion. You are right, we need make sure structure
> > size aligned on 8 bytes, which is important for 32bit-64bit compatible case.
>
>
> While you're at it, please don't use enum as a type inside ioctls, since
> the size can vary by compiler. Please use a uint32_t or whatever instead,
> assigning enum values to that.
Quick correction: You must use __u32 and friends, since using the standard
C typesdef might collide with some program which defines them a different
way. The double underscore ones are explicit ok per the C standard as
private types for the system library. So they're the only ones we can use
in userspace headers.
I've thought checkpatch would bitch about this if you get it wrong, now
that we have the uapi split ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-10-29 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 12:15 [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver Yao Cheng
2014-10-15 9:23 ` Emil Velikov
2014-10-16 14:33 ` Cheng, Yao
2014-10-16 15:20 ` Emil Velikov
2014-10-17 0:36 ` Cheng, Yao
2014-10-17 0:36 ` Jiang, Fei
2014-10-28 16:56 ` Daniel Stone
2014-10-29 7:09 ` Cheng, Yao
2014-10-29 8:14 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029081452.GO26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=fei.jiang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox