From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Wood <thomas.wood@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 2/2] lib/tests: use the "check_" prefix for tests
Date: Mon, 3 Nov 2014 13:39:49 +0100 [thread overview]
Message-ID: <20141103123949.GA26941@phenom.ffwll.local> (raw)
In-Reply-To: <1414603852-5024-2-git-send-email-thomas.wood@intel.com>
On Wed, Oct 29, 2014 at 05:30:52PM +0000, Thomas Wood wrote:
> The "check_" prefix ensures the test programs are not installed and are
> only built when "make check" is run.
>
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
This was actually fairly intentional since when developing I always forget
to hit make check. And if I do I get pissed that make check _always_ runs
all the tests, which is annoying when developing/testing a specific
testcase.
So imo it's better to always build them, but not install them. Ok if I
revert this, or would that break distcheck again?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-03 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 17:30 [PATCH i-g-t 1/2] build: fix distcheck Thomas Wood
2014-10-29 17:30 ` [PATCH i-g-t 2/2] lib/tests: use the "check_" prefix for tests Thomas Wood
2014-11-03 12:39 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103123949.GA26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox