From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
Arthur Runyan <arthur.j.runyan@intel.com>
Subject: Re: [PATCH] drm/i915: HSW/BDW PSR Set idle_frames=2 since sometimes it can be off by 1.
Date: Mon, 3 Nov 2014 13:49:50 +0100 [thread overview]
Message-ID: <20141103124950.GB26941@phenom.ffwll.local> (raw)
In-Reply-To: <1414672555-9421-1-git-send-email-rodrigo.vivi@intel.com>
On Thu, Oct 30, 2014 at 05:35:55AM -0700, Rodrigo Vivi wrote:
> It was identified that in some cases when moving cursor Hardware can do
> mistake with idle_frame count. So Spec is being updated to use
> 2 as minimum idle_frames.
>
> Reference: https://hsdhsw.intel.com/hsd/haswell_platform/default.aspx#sighting/default.aspx?sighting_id=4394433
> Cc: Arthur Runyan <arthur.j.runyan@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Since we have full-blown sw frontbuffer tracking: Do we care?
I.e. is the effect of idle_frames = 1 that the hw will go bananas (bad, we
want this patch) or that it might miss a cursor movement (no problem, the
kernel will catch it anyway)?
Cheers, Daniel
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 47e9d71..8cfbbc2 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2178,7 +2178,7 @@ static void intel_edp_psr_enable_source(struct intel_dp *intel_dp)
> struct drm_device *dev = dig_port->base.base.dev;
> struct drm_i915_private *dev_priv = dev->dev_private;
> uint32_t max_sleep_time = 0x1f;
> - uint32_t idle_frames = 1;
> + uint32_t idle_frames = 2; /* 2 is the minimum allowed */
> uint32_t val = 0x0;
> const uint32_t link_entry_time = EDP_PSR_MIN_LINK_ENTRY_TIME_8_LINES;
> bool only_standby = false;
> --
> 1.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-03 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 12:35 [PATCH] drm/i915: HSW/BDW PSR Set idle_frames=2 since sometimes it can be off by 1 Rodrigo Vivi
2014-11-03 12:49 ` Daniel Vetter [this message]
2014-11-03 17:25 ` Runyan, Arthur J
2014-11-08 0:01 ` Rodrigo Vivi
2014-11-11 10:17 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103124950.GB26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arthur.j.runyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).