From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: fix RPS on runtime suspend
Date: Mon, 3 Nov 2014 17:43:06 +0100 [thread overview]
Message-ID: <20141103164306.GK26941@phenom.ffwll.local> (raw)
In-Reply-To: <1414701383.11645.15.camel@ideak-mobl>
On Thu, Oct 30, 2014 at 10:36:23PM +0200, Imre Deak wrote:
> On Thu, 2014-10-30 at 15:59 -0200, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > With this patch, the RPS sequence for runtime suspend/resume is
> > exactly like the sequence for S3 suspend/resume:
> > - flush_delayed_work(&dev_priv->rps.delayed_resume_work)
> > - intel_runtime_pm_disable_interrupts()
> > - intel_suspend_gt_powersave()
> > (suspended)
> > - intel_runtime_pm_enable_interrupts()
> > - intel_enable_gt_powersave()
> >
> > With this, we get rid of WARNs that are currently intermittently
> > triggered by the system-suspend-execbuf subtest of runtime PM. Notice
> > that these WARNs could also be triggered in other ways that involved
> > doing lots of RPM suspend/resume cycles just after a system S3 resume.
> >
> > Testcase: igt/pm_rpm/system-suspend-execbuf
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> This also fixes some parts of pm_rpm subtest failures on VLV so you
> could add:
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=82939
> and
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Queued for -next, thanks for the patch.
> While fixing the same WARN in the above bug I also cleaned up the rps
> code a bit and made the disabling part more robust against rearming the
> rps work. But that's a separate issue which can't normally happen here,
> so I can send a version rebased on top of your changes.
Yes, please!
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-03 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 17:59 [PATCH] drm/i915: fix RPS on runtime suspend Paulo Zanoni
2014-10-30 20:36 ` Imre Deak
2014-11-03 16:43 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103164306.GK26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox