Re: [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config v2

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Tue, 11 Nov 2014 16:23:03 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Tue, Nov 11, 2014 at 05:19:46PM +0200, Ville Syrjälä wrote:
> > On Tue, Nov 11, 2014 at 04:00:12PM +0100, Daniel Vetter wrote:
> > > On Wed, Nov 05, 2014 at 02:26:08PM -0800, Jesse Barnes wrote:
> > > > This is useful for checking things later.
> > > > 
> > > > v2:
> > > >   - fix hsw infoframe enabled check (Ander)
> > > > 
> > > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > > ---
> > > >  drivers/gpu/drm/i915/intel_drv.h  |  4 +++
> > > >  drivers/gpu/drm/i915/intel_hdmi.c | 62 +++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 66 insertions(+)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> > > > index d53ac23..8aa80e1 100644
> > > > --- a/drivers/gpu/drm/i915/intel_drv.h
> > > > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > > > @@ -292,6 +292,9 @@ struct intel_crtc_config {
> > > >  	 * between pch encoders and cpu encoders. */
> > > >  	bool has_pch_encoder;
> > > >  
> > > > +	/* Are we sending infoframes on the attached port */
> > > > +	bool has_infoframe;
> > > 
> > > The cross-checking of this new hw state is missing. I've added that while
> > > applying.
> > 
> > Where is the compute_config part of this? I can't see it in any patch,
> > but maybe I'm just blind.
> 
> Yeah, seems to be missing, thanks for catching this. Jesse/Ander, can you
> pls supply a fixup quickly - I'd need to drop the series until this one
> otherwise I think.

Ah right missed the other side.  Will post a patch today.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx