From: Daniel Vetter <daniel@ffwll.ch>
To: "O'Rourke, Tom" <Tom.O'Rourke@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Use efficient frequency for HSW/BDW
Date: Tue, 11 Nov 2014 16:11:28 +0100 [thread overview]
Message-ID: <20141111151128.GX25711@phenom.ffwll.local> (raw)
In-Reply-To: <20141107222017.GA93723@torourke-desk1>
On Fri, Nov 07, 2014 at 02:20:17PM -0800, O'Rourke, Tom wrote:
> On Fri, Nov 07, 2014 at 10:50:02AM +0100, Daniel Vetter wrote:
> > > + ret = sandybridge_pcode_read(dev_priv,
> > > + HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL,
> > > + &ddcc_status);
> > > + if (0 == ret)
> > > + dev_priv->rps.efficient_freq = (ddcc_status >> 8) & 0xff;
> >
> > Control flow in the error case looks funny here - shouldn't we put the
> > adjustment of the softlimit into the (ret == 0) case here to avoid putting
> > garbage into it in case the pcode read falls over?
> >
> If the pcode read fails, the efficient_freq will not
> be set here and will still have the non-garbage value
> set in parse_rp_state_cap.
Oh right I've missed this. Maybe update the XXX comment in that function
and replace it with
/* Platforms which support special RP-efficient values will
* overwrite this in their setup fucntions, use rp1_freq as
* default. */
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-11 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 1:31 [PATCH 0/2] Update turbo (rps) min frequency for HSW/BDW Tom.O'Rourke
2014-11-06 1:31 ` [PATCH 1/2] drm/i915: Use efficient " Tom.O'Rourke
2014-11-07 9:50 ` Daniel Vetter
2014-11-07 22:20 ` O'Rourke, Tom
2014-11-11 15:11 ` Daniel Vetter [this message]
2014-11-07 10:41 ` Chris Wilson
2014-11-07 22:25 ` O'Rourke, Tom
2014-11-08 8:25 ` Chris Wilson
2014-11-11 15:13 ` Daniel Vetter
2014-11-11 16:12 ` Chris Wilson
2014-11-12 8:37 ` Daniel Vetter
2014-11-06 1:31 ` [PATCH 2/2] drm/i915: Keep min freq above floor on HSW/BDW Tom.O'Rourke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111151128.GX25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Tom.O'Rourke@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox