From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/ddi: set has_infoframe flag on DDI too
Date: Tue, 18 Nov 2014 09:14:05 +0100 [thread overview]
Message-ID: <20141118081405.GW25711@phenom.ffwll.local> (raw)
In-Reply-To: <1416258527-13789-1-git-send-email-jbarnes@virtuousgeek.org>
On Mon, Nov 17, 2014 at 01:08:46PM -0800, Jesse Barnes wrote:
> Just like we do in the HDMI code, set the infoframe flag if we detect an
> HDMI sink.
>
> Reported-by: Paulo Zanoni <przanoni@gmail.com>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 86745da..78576e0 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2062,6 +2062,7 @@ void intel_ddi_get_config(struct intel_encoder *encoder,
> switch (temp & TRANS_DDI_MODE_SELECT_MASK) {
> case TRANS_DDI_MODE_SELECT_HDMI:
> pipe_config->has_hdmi_sink = true;
> + pipe_config->has_infoframe = true;
Infoframes aren't controlled by this bit here but set in
HSW_TVIDEO_DIP_CTL. Since the point of this is to detect mismatches
between the bios and what we'd like to have for fastboot I think we need
to check that register. Instead of blindly deriving state to appease the
cross checker.
-Daniel
> case TRANS_DDI_MODE_SELECT_DVI:
> case TRANS_DDI_MODE_SELECT_FDI:
> break;
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-18 8:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 21:08 [PATCH 1/2] drm/i915/ddi: set has_infoframe flag on DDI too Jesse Barnes
2014-11-17 21:08 ` [PATCH 2/2] drm/i915/ddi: add break in DDI mode select switch Jesse Barnes
2014-11-18 3:27 ` [PATCH 2/2] drm/i915/ddi: add break in DDI mode select shuang.he
2014-11-18 8:14 ` [PATCH 2/2] drm/i915/ddi: add break in DDI mode select switch Daniel Vetter
2014-11-18 8:14 ` Daniel Vetter [this message]
2014-11-18 16:16 ` [PATCH 1/2] drm/i915/ddi: set has_infoframe flag on DDI too Jesse Barnes
2014-11-18 17:45 ` [PATCH] drm/i915/ddi: set has_infoframe flag on DDI too v2 Jesse Barnes
2014-11-19 0:00 ` [PATCH] drm/i915/ddi: set has_infoframe flag on DDI too shuang.he
2014-11-19 13:53 ` Daniel Vetter
2014-11-19 13:55 ` [PATCH] drm/i915/ddi: set has_infoframe flag on DDI too v2 Daniel Vetter
2014-11-20 15:49 ` Daniel Vetter
2014-11-20 19:54 ` Jesse Barnes
2014-11-20 21:40 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118081405.GW25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox