Re: [PATCH] tests/Android.mk: add gem_fence_upload excluded tests

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Nov 18, 2014 at 03:03:28PM +0000, tim.gore@intel.com wrote:
> From: Tim Gore <tim.gore@intel.com>
> 
> gem_fence_upload implements some performance measurements,
> but fails on both android and linux systems and does not
> generally seem to be a usefull test, so exclude it.
> 
> Signed-off-by: Tim Gore <tim.gore@intel.com>

Nack. Just because the test tests something that doesn't yet work doesn't
mean we should skip it by default.

And if you need skip lists because of your validation process then that
should be managed within your test environment, preferrably per-platform.
-Daniel

> ---
>  tests/Android.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/Android.mk b/tests/Android.mk
> index 519852a..230d709 100644
> --- a/tests/Android.mk
> +++ b/tests/Android.mk
> @@ -31,6 +31,9 @@ skip_tests_list :=
>  skip_tests_list += testdisplay        # needs glib.h
>  skip_tests_list += pm_rpm
>  
> +# some tests are rusty
> +skip_tests_list += gem_fence_upload
> +
>  # set local compilation flags for IGT tests
>  IGT_LOCAL_CFLAGS += -DHAVE_STRUCT_SYSINFO_TOTALRAM -DANDROID -UNDEBUG
>  IGT_LOCAL_CFLAGS += -include "check-ndebug.h" -std=c99
> -- 
> 2.1.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx