From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] drm/atomic: Add missing ERR_PTR casting
Date: Thu, 20 Nov 2014 09:58:52 +0100 [thread overview]
Message-ID: <20141120085851.GC23043@ulmo> (raw)
In-Reply-To: <1416473615-17267-1-git-send-email-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1137 bytes --]
On Thu, Nov 20, 2014 at 09:53:35AM +0100, Daniel Vetter wrote:
> This is an oversight from
>
> commit f52b69f1ecfdd7ef6867a257620258c09e569552
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Wed Nov 19 18:38:08 2014 +0100
>
> drm/atomic: Don't overrun the connector array when hotplugging
>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/drm_atomic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 3624632084e2..d3b46746b611 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -318,7 +318,7 @@ drm_atomic_get_connector_state(struct drm_atomic_state *state,
> */
> if (index >= state->num_connector) {
> DRM_DEBUG_KMS("Hot-added connector would overflow state array, restarting\n");
> - return -EAGAIN;
> + return ERR_PTR(-EAGAIN);
> }
>
> if (state->connector_states[index])
=)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-20 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 8:53 [PATCH] drm/atomic: Add missing ERR_PTR casting Daniel Vetter
2014-11-20 8:58 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120085851.GC23043@ulmo \
--to=thierry.reding@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox