From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: vlv: increase timeout when setting idle GPU freq
Date: Thu, 20 Nov 2014 16:52:28 +0200 [thread overview]
Message-ID: <20141120145228.GZ10649@intel.com> (raw)
In-Reply-To: <1416407138-3262-3-git-send-email-imre.deak@intel.com>
On Wed, Nov 19, 2014 at 04:25:38PM +0200, Imre Deak wrote:
> I saw punit timeouts in vlv_set_rps_idle() while running various
> subtests of pm_rpm. Increasing the timeout to 100ms got rid of the
> issue.
>
> Testcase: igt/pm_rpm
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=82939
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 5cc0ebc..3a58797 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4451,7 +4451,7 @@ static void vlv_set_rps_idle(struct drm_i915_private *dev_priv)
> dev_priv->rps.min_freq_softlimit);
>
> if (wait_for(((vlv_punit_read(dev_priv, PUNIT_REG_GPU_FREQ_STS))
> - & GENFREQSTATUS) == 0, 5))
> + & GENFREQSTATUS) == 0, 100))
If it takes a while then it takes a while. Nothing we can do about
that.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> DRM_ERROR("timed out waiting for Punit\n");
>
> vlv_force_gfx_clock(dev_priv, false);
> --
> 1.8.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-20 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 14:25 [PATCH 0/2] vlv: fix some runtime PM errors Imre Deak
2014-11-19 14:25 ` [PATCH 1/2] drm/i915: vlv: fix cdclk setting during modeset while suspended Imre Deak
2014-11-20 14:49 ` Ville Syrjälä
2014-11-19 14:25 ` [PATCH 2/2] drm/i915: vlv: increase timeout when setting idle GPU freq Imre Deak
2014-11-20 14:12 ` Daniel Vetter
2014-11-20 14:52 ` Ville Syrjälä [this message]
2014-11-21 1:15 ` [PATCH 2/2] drm/i915: vlv: increase timeout when shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120145228.GZ10649@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox