From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com
Subject: Re: [PATCH] drm/i915: remove the IRQs enabled WARN from intel_disable_gt_powersave
Date: Thu, 20 Nov 2014 17:01:22 +0100 [thread overview]
Message-ID: <20141120160122.GI25711@phenom.ffwll.local> (raw)
In-Reply-To: <1416499162-15777-1-git-send-email-imre.deak@intel.com>
On Thu, Nov 20, 2014 at 05:59:22PM +0200, Imre Deak wrote:
> This function can be called now with i915 interrupts enabled, so the
> corresponding WARN is incorrect, remove it. I think this was spotted by
> Paulo during his review, but since I already removed the same WARN
> from intel_suspend_gt_powersave() I missed then his point.
>
> Spotted-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
I think I've just noticed that in the module reload test too. Queued for
-next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-20 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 15:59 [PATCH] drm/i915: remove the IRQs enabled WARN from intel_disable_gt_powersave Imre Deak
2014-11-20 16:01 ` Daniel Vetter [this message]
2014-11-22 14:13 ` [PATCH] drm/i915: remove the IRQs enabled WARN from shuang.he
2014-11-24 9:28 ` Daniel Vetter
2014-11-24 9:58 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120160122.GI25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox