From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Wood <thomas.wood@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] lib: fix igt_reset_connectors
Date: Tue, 25 Nov 2014 09:35:06 +0100 [thread overview]
Message-ID: <20141125083506.GV25711@phenom.ffwll.local> (raw)
In-Reply-To: <1416838585-8324-1-git-send-email-thomas.wood@intel.com>
On Mon, Nov 24, 2014 at 02:16:25PM +0000, Thomas Wood wrote:
> Use igt_debugfs_open to open the connector file, since the
> forced_connectors array now only stores the connector path relative to
> the debugfs path. Also add some extra error checking to ensure a test
> failure if the reset fails.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85829
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
Tested-by: lu hua <huax.lu@intel.com>
And I went right ahead and committed it, thanks.
-Daniel
> ---
> lib/igt_kms.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 5edd5ec..cba0c27 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1773,8 +1773,8 @@ void igt_reset_connectors(void)
> * functions that are not safe to call in signal handlers */
>
> for (tmp = forced_connectors; *tmp; tmp++) {
> - int fd = open(*tmp, O_WRONLY | O_TRUNC);
> - write(fd, "unspecified", 11);
> + int fd = igt_debugfs_open(*tmp, O_WRONLY | O_TRUNC);
> + igt_assert(write(fd, "unspecified", 11) == 11);
> close(fd);
> }
> }
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-25 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 14:16 [PATCH i-g-t] lib: fix igt_reset_connectors Thomas Wood
2014-11-25 8:35 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125083506.GV25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.wood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox