From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Handle runtime pm in the CRC setup code
Date: Tue, 25 Nov 2014 13:58:34 +0100 [thread overview]
Message-ID: <20141125125834.GG25711@phenom.ffwll.local> (raw)
In-Reply-To: <20141125121235.GB2506@strange.ger.corp.intel.com>
On Tue, Nov 25, 2014 at 12:12:35PM +0000, Damien Lespiau wrote:
> On Mon, Nov 24, 2014 at 09:43:12PM +0100, Daniel Vetter wrote:
> > Note that we need the rpm_get/put to make power_is_enabled work
> > properly.
>
> I still don't get that. intel_display_power_is_enabled() only checks for
> states kept in dev_priv. In particular, it doesn't touch the hardware
> and it looks at dev_priv->pm.suspended. So it seems we should be
> covered?
Hm, mixup on my side - we indeed don't check the hw state. Somehow the
check_power_well_state thing confused me. I'll rip the get/put out.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-25 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 15:23 [PATCH] drm/i915: Handle runtime pm in the CRC setup code Daniel Vetter
2014-11-24 15:36 ` Damien Lespiau
2014-11-24 20:11 ` Daniel Vetter
2014-11-24 20:43 ` Daniel Vetter
2014-11-25 11:00 ` [PATCH] drm/i915: Handle runtime pm in the CRC setup shuang.he
2014-11-25 12:12 ` [PATCH] drm/i915: Handle runtime pm in the CRC setup code Damien Lespiau
2014-11-25 12:58 ` Daniel Vetter [this message]
2014-11-25 13:08 ` Daniel Vetter
2014-11-25 13:33 ` Damien Lespiau
2014-11-26 7:32 ` [PATCH] drm/i915: Handle runtime pm in the CRC setup shuang.he
2014-11-25 1:20 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125125834.GG25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox