Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: akash.goel@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Update in Gen9 multi-engine forcewake range
Date: Tue, 25 Nov 2014 14:16:24 +0100	[thread overview]
Message-ID: <20141125131624.GL25711@phenom.ffwll.local> (raw)
In-Reply-To: <20141125122655.GC2506@strange.ger.corp.intel.com>

On Tue, Nov 25, 2014 at 12:26:55PM +0000, Damien Lespiau wrote:
> On Tue, Nov 25, 2014 at 12:29:00PM +0530, akash.goel@intel.com wrote:
> > From: Akash Goel <akash.goel@intel.com>
> > 
> > Updates in forcewake range for Render/Media/Common
> > power wells for Gen9.
> > 
> > Signed-off-by: Akash Goel <akash.goel@intel.com>
> > Signed-off-by: Zhe Wang <zhe1.wang@intel.com>

Aside: Last sob line should be the person who submits the patch, first one
the original author. Otherwise your internal hand-off process is screwed
up. If you want to acknowledge earlier contributors either do that in the
commit message ("Based upon a patch from ...") and add the person to the
Cc: list. Or have an in-patch changelog and make it clear which s-o-b line
is for which version of the patch (they way Damien&I handle internal
patches).

Remember that the sob line essentially amounts to signing a legal
statement, so this should be done with care.

> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2014-11-25 13:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25  6:59 [PATCH] drm/i915/skl: Update in Gen9 multi-engine forcewake range akash.goel
2014-11-25 12:26 ` Damien Lespiau
2014-11-25 13:16   ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141125131624.GL25711@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=akash.goel@intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox