From: Tom Stellard <tom@stellard.net>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/dp: retry AUX transactions 32 times
Date: Tue, 25 Nov 2014 22:20:28 -0500 [thread overview]
Message-ID: <20141126032028.GB12928@yyz> (raw)
In-Reply-To: <1416971843-2122-1-git-send-email-airlied@gmail.com>
On Wed, Nov 26, 2014 at 01:17:22PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> At least on two MST devices I've tested with, when
> they are link training downstream, they are totally
> unable to handle aux ch msgs, so they defer like nuts.
> I tried 16, it wasn't enough, 32 seems better.
>
> This fixes one Dell 4k monitor and one of the
> MST hubs.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 959e207..db0993f 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -189,7 +189,7 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
> * retry native transactions, so retry 7 times like for I2C-over-AUX
Should this comment be updated too?
-Tom
> * transactions.
> */
> - for (retry = 0; retry < 7; retry++) {
> + for (retry = 0; retry < 32; retry++) {
>
> mutex_lock(&aux->hw_mutex);
> err = aux->transfer(aux, &msg);
> --
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-11-26 3:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 3:17 [PATCH 1/2] drm/dp: retry AUX transactions 32 times Dave Airlie
2014-11-26 3:17 ` [PATCH 2/2] drm/fb_helper: move deferred fb checking into restore mode Dave Airlie
2014-11-26 7:39 ` [Intel-gfx] " Daniel Vetter
2014-11-26 17:37 ` [PATCH 2/2] drm/fb_helper: move deferred fb checking shuang.he
2014-11-26 3:20 ` Tom Stellard [this message]
2014-11-26 3:22 ` [PATCH 1/2] drm/dp: retry AUX transactions 32 times Dave Airlie
2014-11-26 9:24 ` Jani Nikula
2014-12-08 23:55 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126032028.GB12928@yyz \
--to=tom@stellard.net \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox