From: Daniel Vetter <daniel@ffwll.ch>
To: "Daniel, Thomas" <thomas.daniel@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Call the lrc irq handler correctly
Date: Mon, 15 Dec 2014 09:54:27 +0100 [thread overview]
Message-ID: <20141215085427.GE27182@phenom.ffwll.local> (raw)
In-Reply-To: <BFEE8FEC12424048AF1805991D65FA9119703260@IRSMSX105.ger.corp.intel.com>
On Wed, Dec 10, 2014 at 04:56:39PM +0000, Daniel, Thomas wrote:
> > -----Original Message-----
> > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch]
> > Sent: Wednesday, December 10, 2014 4:44 PM
> > To: Intel Graphics Development
> > Cc: Daniel Vetter; Daniel, Thomas; Vetter, Daniel
> > Subject: [PATCH] drm/i915: Call the lrc irq handler correctly
> >
> > We consistently use the _irq_handler postfix for functions called in hardirq
> > context. Especially when it's a non-static function hardirq is a crazy enough
> > calling context to warrant this level of ocd. So rename it.
> >
> > Cc: Thomas Daniel <thomas.daniel@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> Possible to rename the patch "Name the lrc irq handler correctly" before
> merging? Sounds like it was being called from the wrong place.
Definitely agreed since I've changed the subject locally 1 second after
hitting send ;-)
>
> No problem with this renaming though so:
> Reviewed-by: Thomas Daniel <thomas.daniel@intel.com>
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-12-15 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 16:43 [PATCH] drm/i915: Call the lrc irq handler correctly Daniel Vetter
2014-12-10 16:56 ` Daniel, Thomas
2014-12-15 8:54 ` Daniel Vetter [this message]
2014-12-11 3:29 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141215085427.GE27182@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thomas.daniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox