From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Mika Kuoppala <mika.kuoppala@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: Remove bogus locking check in the hangcheck code
Date: Tue, 3 Feb 2015 12:09:47 +0100 [thread overview]
Message-ID: <20150203110947.GI14009@phenom.ffwll.local> (raw)
In-Reply-To: <20150203105027.GB26272@nuc-i3427.alporthouse.com>
On Tue, Feb 03, 2015 at 10:50:27AM +0000, Chris Wilson wrote:
> On Tue, Feb 03, 2015 at 11:49:00AM +0100, Daniel Vetter wrote:
> > Aside: It is possible to check whether a given task doesn't hold a
> > lock, but only when lockdep is enabled, using the lockdep_assert_held
> > stuff.
>
> Bah. That's what I said, but a certain Daniel insists on using WARN_ON().
That is for the inverse check which warns when the lock is not taking,
i.e. WARN_ON(!mutex_is_locked). lockdep_assert_held would be more
accurate but also won't work at all if disabled. We run single-threaded by
accident often enough that the reduced practical coverage trumps the
reduced theoretical coverage imo.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-03 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 10:49 [PATCH] drm/i915: Remove bogus locking check in the hangcheck code Daniel Vetter
2015-02-03 10:50 ` Chris Wilson
2015-02-03 11:09 ` Daniel Vetter [this message]
2015-02-03 11:00 ` Chris Wilson
2015-02-03 11:14 ` Daniel Vetter
2015-02-03 11:17 ` Chris Wilson
2015-02-03 13:57 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203110947.GI14009@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox