From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
akash.goel@intel.com, intel-gfx@lists.freedesktop.org,
ankitprasad.r.sharma@intel.com
Subject: Re: [PATCH v2] drm/i915: Removed the read of RP_STATE_CAP from sysfs/debugfs functions
Date: Thu, 26 Feb 2015 14:29:40 +0100 [thread overview]
Message-ID: <20150226132940.GN24485@phenom.ffwll.local> (raw)
In-Reply-To: <20150226103828.GF8131@nuc-i3427.alporthouse.com>
On Thu, Feb 26, 2015 at 10:38:28AM +0000, Chris Wilson wrote:
> On Thu, Feb 26, 2015 at 04:09:47PM +0530, akash.goel@intel.com wrote:
> > From: Akash Goel <akash.goel@intel.com>
> >
> > The frequency values(Rp0, Rp1, Rpn) reported by RP_STATE_CAP register
> > are stored, initially by the Driver, inside the dev_priv->rps structure.
> > Since these values are expected to remain same throughout, there is no real
> > need to read this register, on dynamic basis, from certain debugfs/sysfs
> > functions and the values can be instead retrieved from the dev_priv->rps
> > structure when needed.
> > For the i915_frequency_info debugfs interface, the frequency values from the
> > RP_STATE_CAP register only should be used, to indicate the actual Hw state,
> > since it is principally used for the debugging purpose.
> >
> > v2: Reverted the changes in i915_frequency_info function, to continue report
> > back the frequency values, as per the actual Hw state (Chris)
> >
> > Signed-off-by: Akash Goel <akash.goel@intel.com>
> Nice improvement,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-26 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 10:39 [PATCH v2] drm/i915: Removed the read of RP_STATE_CAP from sysfs/debugfs functions akash.goel
2015-02-26 10:38 ` Chris Wilson
2015-02-26 13:29 ` Daniel Vetter [this message]
2015-02-27 23:58 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226132940.GN24485@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akash.goel@intel.com \
--cc=ankitprasad.r.sharma@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox