From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/skl: Support for 90/270 rotation
Date: Thu, 5 Mar 2015 15:08:17 +0200 [thread overview]
Message-ID: <20150305130817.GE11371@intel.com> (raw)
In-Reply-To: <20150305125653.GC18775@phenom.ffwll.local>
On Thu, Mar 05, 2015 at 01:56:53PM +0100, Daniel Vetter wrote:
> On Thu, Mar 05, 2015 at 02:51:28PM +0530, Sonika Jindal wrote:
> > @@ -1519,16 +1550,7 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane)
> > goto out;
> > }
> >
> > - if (!dev->mode_config.rotation_property)
> > - dev->mode_config.rotation_property =
> > - drm_mode_create_rotation_property(dev,
> > - BIT(DRM_ROTATE_0) |
> > - BIT(DRM_ROTATE_180));
> > -
> > - if (dev->mode_config.rotation_property)
> > - drm_object_attach_property(&intel_plane->base.base,
> > - dev->mode_config.rotation_property,
> > - state->base.rotation);
> > + intel_create_rotation_property(dev, intel_plane);
>
> I think back from the original rotation work we've had the leftover task
> to move this into common code so that we do create the property just once
> without this check.
>
> I think this should be done now.
Someone should also make it so we can again have different supported
rotation bits on different planes. I'll have need for it on CHV I think.
> -Daniel
> >
> > drm_plane_helper_add(&intel_plane->base, &intel_plane_helper_funcs);
> >
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-05 13:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 9:21 [PATCH 1/3] drm/i915/skl: Allow universal planes to position Sonika Jindal
2015-03-05 9:21 ` [PATCH 2/3] drm/i915: Using plane state parameters instead of pipe's Sonika Jindal
2015-03-05 13:01 ` Daniel Vetter
2015-03-05 9:21 ` [PATCH 3/3] drm/i915/skl: Support for 90/270 rotation Sonika Jindal
2015-03-05 12:56 ` Daniel Vetter
2015-03-05 13:08 ` Ville Syrjälä [this message]
2015-03-05 15:29 ` Daniel Vetter
2015-03-05 15:56 ` Ville Syrjälä
2015-03-06 17:03 ` Daniel Vetter
2015-03-06 17:22 ` Ville Syrjälä
2015-03-06 17:38 ` Daniel Vetter
2015-03-05 12:54 ` [PATCH 1/3] drm/i915/skl: Allow universal planes to position Daniel Vetter
2015-03-09 3:03 ` sonika
2015-03-09 8:46 ` Daniel Vetter
2015-03-09 15:20 ` Ville Syrjälä
2015-03-09 15:31 ` Daniel Vetter
2015-03-10 3:53 ` sonika
2015-03-10 10:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305130817.GE11371@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox