From: Damien Lespiau <damien.lespiau@intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings
Date: Sat, 7 Mar 2015 00:09:08 +0000 [thread overview]
Message-ID: <20150307000908.GA17168@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1425686012-1824-1-git-send-email-jbarnes@virtuousgeek.org>
On Fri, Mar 06, 2015 at 03:53:32PM -0800, Jesse Barnes wrote:
> So try to enumerate eDP unconditionally in those cases.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
That's WaIgnoreDDIAStrap, I assumed it actually worked since my eDP
panel was detected... I see it listed without a stepping check but I
guess you have a good source for that one.
So, maybe with the WaIgnoreDDIAStrap mention:
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_display.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 597c10b..8820e8a 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12563,10 +12563,15 @@ static void intel_setup_outputs(struct drm_device *dev)
> if (HAS_DDI(dev)) {
> int found;
>
> - /* Haswell uses DDI functions to detect digital outputs */
> + /*
> + * Haswell uses DDI functions to detect digital outputs.
> + * On SKL pre-D0 the strap isn't connected, so we assume
> + * it's there.
> + */
> found = I915_READ(DDI_BUF_CTL_A) & DDI_INIT_DISPLAY_DETECTED;
> /* DDI A only supports eDP */
> - if (found)
> + if (found ||
> + (IS_SKYLAKE(dev) && INTEL_REVID(dev) < SKL_REVID_D0))
> intel_ddi_init(dev, PORT_A);
>
> /* DDI B, C and D detection is indicated by the SFUSE_STRAP
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-07 0:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 23:53 [PATCH] drm/i915/skl: port A fuse straps don't work on early SKL steppings Jesse Barnes
2015-03-07 0:09 ` Damien Lespiau [this message]
2015-03-09 9:03 ` Daniel Vetter
2015-03-09 15:18 ` Jesse Barnes
2015-03-09 15:56 ` Damien Lespiau
2015-03-07 3:21 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150307000908.GA17168@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox