Re: [PATCH v2] i-g-t: Adding test case to test background color.

From: Daniel Vetter <daniel@ffwll.ch>
To: "Konduru, Chandra" <chandra.konduru@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] i-g-t: Adding test case to test background color.
Date: Wed, 25 Mar 2015 14:48:33 +0100	[thread overview]
Message-ID: <20150325134833.GH1349@phenom.ffwll.local> (raw)
In-Reply-To: <76A9B330A4D78C4D99CB292C4CC06C0E36F8129E@fmsmsx101.amr.corp.intel.com>

On Tue, Mar 24, 2015 at 06:51:43PM +0000, Konduru, Chandra wrote:
> > Please use igt_interactive_debug if you want to make a testcase useful for visual
> > inspection. But igts _really_ must run fully automated, and that's possible using
> > crc checksums. I.e. you need to draw reference frames using software, grab crc
> > checksums and then compare against the same composition using the hw
> > feature.
> 
> Initially I planned to use crcs, but issue is that when all planes are disabled,
> which is required for this test, crcs aren't reliable to depend for comparison. 
> Will sendout updated patch with sleeps takenout.

Funny that crcs don't work when all planes are disabled, we should still
be scanning out a proper black. And the crcs we use by default are all at
the pipe leve. What exactly falls apart?

> By the way, also I tried using igt_interactive_debug() but execution doesn't
> wait for keypress in response to calling igt_debug_wait_for_keypress.
> I might be missing something here. Is there a sample sequence
> to use igt_interactive_debug? 

You need to enable it with --interactive-debug=all The help text for that
functions even explains that ...

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx