From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: kill i915.powersave
Date: Thu, 26 Mar 2015 13:26:53 +0100 [thread overview]
Message-ID: <20150326122642.GA24805@phenom.ffwll.local> (raw)
In-Reply-To: <5513EE17.90200@linux.intel.com>
On Thu, Mar 26, 2015 at 11:31:35AM +0000, Tvrtko Ursulin wrote:
>
> On 03/25/2015 01:45 PM, Daniel Vetter wrote:
> >On Tue, Mar 24, 2015 at 08:50:34PM +0000, Chris Wilson wrote:
> >>On Tue, Mar 24, 2015 at 12:40:09PM -0700, Rodrigo Vivi wrote:
> >>>This flag was being mostly used as a meta flag in some
> >>>cases and not covering other cases.
> >>>
> >>>One of the risks is that it was masking some frontbuffer
> >>>trackings without disabling PSR.
> >>>
> >>>So, better to kill this at once and avoid umbrella parameters.
> >>>
> >>>Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >>
> >>Agreed. Its purpose was never entirely clear and its value in debugging
> >>was the same as using an elephant gun to shot at a gnat.
> >>
> >>Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> >Queued for -next, thanks for the patch.
>
> There is an unused out label after this patch which causes a compiler
> warning. Would have sent a patch but I think you sometimes intervene
> manually in the tree for trivial things so did not bother.
Already spotted and squashed away but not yet pushed out.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-26 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 19:40 [PATCH] drm/i915: kill i915.powersave Rodrigo Vivi
2015-03-24 20:50 ` Chris Wilson
2015-03-25 13:45 ` Daniel Vetter
2015-03-26 11:31 ` Tvrtko Ursulin
2015-03-26 12:26 ` Daniel Vetter [this message]
2015-03-25 1:20 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326122642.GA24805@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox