public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Chandra Konduru <chandra.konduru@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: reset drm state backpointer in crtc_state
Date: Wed, 8 Apr 2015 10:22:11 +0200	[thread overview]
Message-ID: <20150408082211.GR6354@phenom.ffwll.local> (raw)
In-Reply-To: <1428345029-13880-1-git-send-email-chandra.konduru@intel.com>

On Mon, Apr 06, 2015 at 11:30:29AM -0700, Chandra Konduru wrote:
> At end of intel_crtc_set_config, reset crtc_state's
> drm_state back pointer to null.
> 
> Signed-off-by: Chandra Konduru <chandra.konduru@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c84926b..f9c2e4d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12451,8 +12451,10 @@ fail:
>  	}
>  
>  out_config:
> -	if (state)
> +	if (state) {
>  		drm_atomic_state_free(state);
> +		to_intel_crtc(set->crtc)->config->base.state = NULL;

This should be done in intel_crtc_set_state instead of just in this case
here.
-Daniel

> +	}
>  
>  	intel_set_config_free(config);
>  	return ret;
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2015-04-08  8:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06 18:30 [PATCH] drm/i915: reset drm state backpointer in crtc_state Chandra Konduru
2015-04-06 20:52 ` shuang.he
2015-04-07  9:02 ` Jani Nikula
2015-04-07 18:48   ` Konduru, Chandra
2015-04-08  8:19     ` Daniel Vetter
2015-04-08 16:26       ` Konduru, Chandra
2015-04-08  8:22 ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150408082211.GR6354@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chandra.konduru@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox