From: Daniel Vetter <daniel@ffwll.ch>
To: sagar.a.kamble@intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/i915: Disable Render power gating
Date: Fri, 10 Apr 2015 16:16:03 +0200 [thread overview]
Message-ID: <20150410141603.GK6092@phenom.ffwll.local> (raw)
In-Reply-To: <1428667354-22366-1-git-send-email-sagar.a.kamble@intel.com>
On Fri, Apr 10, 2015 at 05:32:34PM +0530, sagar.a.kamble@intel.com wrote:
> From: Sagar Kamble <sagar.a.kamble@intel.com>
>
> When RC6 along with Render power gating is enabled, GPU hang
> happens due to lack of synchronization between GTI and Render
> power gating.
>
When resending patches please have a per-patch changelog here. And if the
patch is reviewed please also add all these tags when resending. Otherwise
the patch gets lost easily.
Merged the first one meanwhile, thanks.
-Daniel
> Change-Id: If1614206341eb52a21eadae8c5ebb2655029b50c
> Signed-off-by: Sagar Kamble <sagar.a.kamble@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 9975401..4dd8b41 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4350,9 +4350,12 @@ static void gen9_enable_rc6(struct drm_device *dev)
> GEN6_RC_CTL_EI_MODE(1) |
> rc6_mask);
>
> - /* 3b: Enable Coarse Power Gating only when RC6 is enabled */
> + /*
> + * 3b: Enable Coarse Power Gating only when RC6 is enabled.
> + * WaDisableRenderPowerGating:skl,bxt - Render PG need to be disabled with RC6.
> + */
> I915_WRITE(GEN9_PG_ENABLE, (rc6_mask & GEN6_RC_CTL_RC6_ENABLE) ?
> - (GEN9_RENDER_PG_ENABLE | GEN9_MEDIA_PG_ENABLE) : 0);
> + GEN9_MEDIA_PG_ENABLE : 0);
>
>
> intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
> --
> 1.8.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-04-10 14:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 8:41 [PATCH 1/2] drm/i915: Naming constants to be written to GEN9_PG_ENABLE sagar.a.kamble
2015-04-10 8:41 ` [PATCH 2/2] drm/i915: Disable Render power gating sagar.a.kamble
2015-04-10 8:50 ` Damien Lespiau
2015-04-10 11:11 ` Damien Lespiau
2015-04-10 12:02 ` [PATCH 1/1] " sagar.a.kamble
2015-04-10 14:16 ` Daniel Vetter [this message]
2015-04-12 5:58 ` [PATCH v2 " sagar.a.kamble
2015-04-13 9:24 ` Daniel Vetter
2015-04-10 8:57 ` [PATCH 1/2] drm/i915: Naming constants to be written to GEN9_PG_ENABLE Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410141603.GK6092@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox