From: Damien Lespiau <damien.lespiau@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [PATCH libdrm] intel: Leak the userptr test bo
Date: Wed, 29 Apr 2015 15:27:45 +0100 [thread overview]
Message-ID: <20150429142745.GC21471@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20150417112200.GA31089@nuc-i3427.alporthouse.com>
On Fri, Apr 17, 2015 at 12:22:00PM +0100, Chris Wilson wrote:
> On Fri, Apr 17, 2015 at 11:57:28AM +0100, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > In order to use userptr, the kernel tracks the owner's mm with a
> > mmu_notifier. Setting that is very expensive - it involves taking all
> > mm_locks and a stop_machine(). This tracking lives only for as long as
> > the client is using userptr objects - so if the client allocates then
> > frees a userptr in a loop, we will be executing that heavyweight setup
> > everytime. To ammoritize this cost, just leak the test bo and the single
> > backing page we use for detecting userptr.
> >
> > v2: Free the object and memory when bufmgr is destroyed.
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Reveiwed-by: Chris Wilson <chris@chris-wilson.co.uk>
s/vei/vie/ and merged. Thanks for the patch and review (could it be time
to ask for push access?)
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-04-29 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 10:57 [PATCH libdrm] intel: Leak the userptr test bo Tvrtko Ursulin
2015-04-17 11:22 ` Chris Wilson
2015-04-29 14:27 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429142745.GC21471@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=tvrtko.ursulin@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox