Re: [PATCH igt] lib/debugfs: wait_for_keypress("crc") when collecting CRC

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, May 08, 2015 at 11:07:30AM -0300, Paulo Zanoni wrote:
> 2015-05-08 4:29 GMT-03:00 Daniel Vetter <daniel@ffwll.ch>:
> > On Thu, May 07, 2015 at 03:23:17PM -0300, Paulo Zanoni wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> Let's just steal the "crc" namespace and add this by default to
> >> igt_pipe_crc_collect_crc() instead of adding more calls to other
> >> tests. If tests want special waits on just some of their collect_crc()
> >> calls, they can use another name instead of "crc".
> >>
> >> This is very useful when developing, especially when the CRC we get is
> >> wrong: we want to look at the screen to see what's going on before we
> >> can think about how to fix the problem. So let's add this to the lib
> >> instead of adding this to every single test I need to debug.
> >>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > My idea was that we'd only capture crc for test pictures and not reference
> > pictures.
> 
> And how do we differentiate this inside the lib? This patch was
> suggested by you while reviewing one of my previous patches. You
> explicitly said we should have the wait_for_keypress("crc") call
> inside igt_pipe_crc_collect_crc().
> 
> Since the library can't guess what's what, if someone wants to get
> just the test pictures, they should add their own
> wait_for_keypress("somethingelse") calls.

Fully agreed, my comment wasn't meant as critique, just some information
why I didn't do this right away.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx