Re: [PATCH 2/2] drm/i915/skl: Add debug messages at the start/end of DMC firmware loading

[Damien Lespiau <damien.lespiau@intel.com>]

On Thu, Jun 04, 2015 at 04:47:00PM +0100, Chris Wilson wrote:
> On Thu, Jun 04, 2015 at 04:42:16PM +0100, Damien Lespiau wrote:
> > It's handy to have debug message for the "big" events and this one
> > qualifies IMHO. Also helpful to see what's happening while we're loading
> > the firwmare and how much time it takes.
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_csr.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> > index aae0652..2cf25ee 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -389,6 +389,7 @@ static void finish_csr_load(const struct firmware *fw, void *context)
> >  	intel_csr_load_program(dev);
> >  	fw_loaded = true;
> >  
> > +	DRM_DEBUG_KMS("Finished loading %s\n", dev_priv->csr.fw_path);
> 
> KMS? DRM_DEBUG_DRIVER() as it is off wider scope.

Is it? AFAIK the DMC is all about saving/restoring display registers
when we toggle the power wells between frame updates for eDP + PSR
panels.

But then I guess the loading itself is a generic driver function.

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx