From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Don't set cursor rotate bits when cursor is disabled
Date: Thu, 25 Jun 2015 14:12:53 +0200 [thread overview]
Message-ID: <20150625121253.GQ25769@phenom.ffwll.local> (raw)
In-Reply-To: <1435172376-9597-3-git-send-email-ville.syrjala@linux.intel.com>
On Wed, Jun 24, 2015 at 09:59:36PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Let's keep the cursor control register at 0 when the cursor is disabled.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
All merged, with the slight naming bikeshed we discussed on irc squashed
into patch 1.
Thanks, Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index cd8fa05..29c584c 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9896,10 +9896,10 @@ static void i9xx_update_cursor(struct drm_crtc *crtc, u32 base)
>
> if (IS_HASWELL(dev) || IS_BROADWELL(dev))
> cntl |= CURSOR_PIPE_CSC_ENABLE;
> - }
>
> - if (crtc->cursor->state->rotation == BIT(DRM_ROTATE_180))
> - cntl |= CURSOR_ROTATE_180;
> + if (crtc->cursor->state->rotation == BIT(DRM_ROTATE_180))
> + cntl |= CURSOR_ROTATE_180;
> + }
>
> if (intel_crtc->cursor_cntl != cntl) {
> I915_WRITE(CURCNTR(pipe), cntl);
> --
> 2.3.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-25 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 18:59 [PATCH 1/3] drm/i915: Store frontbuffer_bits in the plane ville.syrjala
2015-06-24 18:59 ` [PATCH 2/3] drm/i915: Add debug messages for pipe enable/disable ville.syrjala
2015-06-24 18:59 ` [PATCH 3/3] drm/i915: Don't set cursor rotate bits when cursor is disabled ville.syrjala
2015-06-25 12:12 ` Daniel Vetter [this message]
2015-06-25 7:53 ` [PATCH 1/3] drm/i915: Store frontbuffer_bits in the plane Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625121253.GQ25769@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox