From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
bing.niu@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Also perform gpu reset under execlist mode.
Date: Thu, 25 Jun 2015 15:20:54 +0200 [thread overview]
Message-ID: <20150625132054.GS25769@phenom.ffwll.local> (raw)
In-Reply-To: <20150625081313.GG30757@nuc-i3427.alporthouse.com>
On Thu, Jun 25, 2015 at 09:13:13AM +0100, Chris Wilson wrote:
> On Thu, Jun 25, 2015 at 10:40:15PM +0800, bing.niu@intel.com wrote:
> > From: "Niu,Bing" <bing.niu@intel.com>
> >
> > It is found that i915 will not reset gpu under execlist mode when
> > unload module. that will lead to some issues when unload/load module
> > with different submission mode. e.g. from execlist mode to ring
> > buffer mode via loading/unloading i915. Because HW is not in a reset
> > state and registers are not clean under such condition.
>
> Now the reason we have the reset there is to disable writes to the power
> context after the memory is released. Your complaint above can easily be
> read as the driver is unable to correctly initialisae itself from a
> random GPU state, which is a fault in driver initialisation.
>
> Have you observed stray memory writes from the GPU after the module is
> unloaded? If not, this would seem to be just a band-aid.
I think as long as we don't have any bios out there enabling execlist
already it's better to try to leave the gpu behind in a state consistent
what we're seeing from real firmware. Otherwise we just have complexity
for no reason.
Similar example is that we kill all outputs since our pte setup doesn't
math the bios one (and yeah I think there too it'd be good to fill out the
gtt with stolen ptes). Hence this patch makes sense for me.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-25 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 14:40 [PATCH] drm/i915: Also perform gpu reset under execlist mode bing.niu
2015-06-25 8:13 ` Chris Wilson
2015-06-25 12:24 ` Wang, Zhi A
2015-06-25 12:37 ` Chris Wilson
2015-06-24 21:56 ` Zhi Wang
2015-06-25 13:42 ` Chris Wilson
2015-06-24 22:13 ` Zhi Wang
2015-06-25 13:20 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625132054.GS25769@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=bing.niu@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox