From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Paulo Zanoni <przanoni@gmail.com>,
intel-gfx@lists.freedesktop.org,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 8/8] drm/i915: protect FBC functions with FBC checks
Date: Mon, 6 Jul 2015 14:34:48 +0200 [thread overview]
Message-ID: <20150706123448.GW2156@phenom.ffwll.local> (raw)
In-Reply-To: <20150703185031.GX14231@nuc-i3427.alporthouse.com>
On Fri, Jul 03, 2015 at 07:50:31PM +0100, Chris Wilson wrote:
> On Fri, Jul 03, 2015 at 03:40:54PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > Now all the functions called by other files check whether FBC has been
> > initialized. This allows us to drop the checks on the static
> > functions.
> >
> > v2:
> > - s/HAS_FBC/dev_priv->display.enable_fbc/ everywhere but the init
> > function (Chris).
> >
> > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_fbc.c | 27 ++++++++++++++++++---------
> > 1 file changed, 18 insertions(+), 9 deletions(-)
> >
> >
> > I'm not 100% sure this is what Chris was asking for v2, so please clarify if
> > this is not what we want.
>
> Does the trick for me,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Entire series merged to dinq, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-07-06 12:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 22:25 [PATCH 0/8] FBC (+stolen) locking, v5 Paulo Zanoni
2015-07-02 22:25 ` [PATCH 1/8] drm/i915: add simple wrappers for stolen node insertion/removal Paulo Zanoni
2015-07-03 16:01 ` Chris Wilson
2015-07-02 22:25 ` [PATCH 2/8] drm/i915: move FBC code out of i915_gem_stolen.c Paulo Zanoni
2015-07-03 16:01 ` Chris Wilson
2015-07-02 22:25 ` [PATCH 3/8] drm/i915: add dev_priv->mm.stolen_lock Paulo Zanoni
2015-07-03 16:00 ` Chris Wilson
2015-07-02 22:25 ` [PATCH 4/8] drm/i915: add the FBC mutex Paulo Zanoni
2015-07-02 22:25 ` [PATCH 5/8] drm/i915: intel_frontbuffer_flip_prepare() doesn't need struct_mutex Paulo Zanoni
2015-07-02 22:25 ` [PATCH 6/8] drm/i915: intel_unregister_dsm_handler() " Paulo Zanoni
2015-07-02 22:25 ` [PATCH 7/8] drm/i915: FBC doesn't need struct_mutex anymore Paulo Zanoni
2015-07-02 22:25 ` [PATCH 8/8] drm/i915: protect FBC functions with HAS_FBC checks Paulo Zanoni
2015-07-03 15:56 ` Chris Wilson
2015-07-03 16:03 ` Chris Wilson
2015-07-03 17:59 ` Paulo Zanoni
2015-07-03 18:23 ` Chris Wilson
2015-07-03 18:40 ` [PATCH 8/8] drm/i915: protect FBC functions with FBC checks Paulo Zanoni
2015-07-03 18:50 ` Chris Wilson
2015-07-06 12:34 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706123448.GW2156@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox