public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
	"Hanno Böck" <hanno@hboeck.de>,
	intel-gfx@lists.freedesktop.org
Subject: Re: Error in inner loop in validate_cmds_sorted / out of bounds issue
Date: Tue, 28 Jul 2015 10:14:51 +0200	[thread overview]
Message-ID: <20150728081451.GC16722@phenom.ffwll.local> (raw)
In-Reply-To: <20150728074551.GB27074@nuc-i3427.alporthouse.com>

On Tue, Jul 28, 2015 at 08:45:51AM +0100, Chris Wilson wrote:
> On Mon, Jul 27, 2015 at 09:15:32PM -0700, Hanno Böck wrote:
> > On Mon, 27 Jul 2015 09:59:45 +0100
> > Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > 
> > > The tables aren't sorted, that is worth fixing.
> > 
> > Attached patch should do that and fix the loop. Now it boots without
> > errors.
> > 
> > Does that look okay? If so please apply.
> 
> Indeed, nice catch. Could you please read
> Documentation/SubmittingPatches and apply your Signed-off-by and then we
> can accept this patch under your authorship.
> 
> Preferrably this is two patches, (a) fix the tables, (b) fix the
> validator. That way we can delay enabling the validator if we need to
> fix the tables for others.

Also can you please add signed-off-by lines to your patch when
resubmitting? See Documentation/SubmittingPatches for all the details.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-07-28  8:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-26  1:56 Error in inner loop in validate_cmds_sorted / out of bounds issue Hanno Böck
2015-07-27  8:59 ` Chris Wilson
2015-07-28  4:15   ` Hanno Böck
2015-07-28  7:45     ` Chris Wilson
2015-07-28  8:14       ` Daniel Vetter [this message]
2015-07-28 18:14         ` Hanno Böck
2015-07-28 19:36           ` Chris Wilson
2015-07-29  8:33             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150728081451.GC16722@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chris@chris-wilson.co.uk \
    --cc=hanno@hboeck.de \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox