From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
sourab.gupta@intel.com, intel-gfx@lists.freedesktop.org,
Robert Bragg <robert@sixbynine.org>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Jon Bloomfield <jon.bloomfield@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jabin Wu <jabin.wu@intel.com>, Insoo Woo <insoo.woo@intel.com>
Subject: Re: [RFC 7/8] drm/i915: Add support for forwarding execbuffer tags in timestamp sample metadata
Date: Wed, 5 Aug 2015 11:29:38 +0200 [thread overview]
Message-ID: <20150805092938.GU17734@phenom.ffwll.local> (raw)
In-Reply-To: <20150805091755.GD10387@nuc-i3427.alporthouse.com>
On Wed, Aug 05, 2015 at 10:17:55AM +0100, Chris Wilson wrote:
> On Wed, Aug 05, 2015 at 11:25:43AM +0530, sourab.gupta@intel.com wrote:
> > @@ -555,10 +558,12 @@ static void forward_one_gen_pmu_sample(struct drm_i915_private *dev_priv,
> > struct drm_i915_ts_node_ctx_id *ctx_info;
> > struct drm_i915_ts_node_ring_id *ring_info;
> > struct drm_i915_ts_node_pid *pid_info;
> > + struct drm_i915_ts_node_tag *tag_info;
> > struct perf_raw_record raw;
> >
> > BUILD_BUG_ON((TS_DATA_SIZE != 8) || (CTX_INFO_SIZE != 8) ||
> > - (RING_INFO_SIZE != 8) || (PID_INFO_SIZE != 8));
> > + (RING_INFO_SIZE != 8) || (PID_INFO_SIZE != 8) ||
> > + (TAG_INFO_SIZE != 8));
>
> This is much more useful if each clause is independent. The error
> message is then unambiguous and it looks neater.
>
> > snapshot = dev_priv->gen_pmu.buffer.addr + node->offset;
> > snapshot_size = TS_DATA_SIZE + CTX_INFO_SIZE;
>
> > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
> > index 3dcc862..db91098 100644
> > --- a/include/uapi/drm/i915_drm.h
> > +++ b/include/uapi/drm/i915_drm.h
> > @@ -104,7 +104,8 @@ struct drm_i915_gen_pmu_attr {
> > __u32 size;
> > __u32 sample_ring:1,
> > sample_pid:1,
> > - __reserved_1:30;
> > + sample_tag:1,
> > + __reserved_1:29;
>
> Start each bitfield entry on its own line with __u32;
also no bitfields in uapi headers.
-Daniel
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-05 9:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 5:55 [RFC 0/8] Introduce framework for forwarding generic non-OA performance sourab.gupta
2015-08-05 5:55 ` [RFC 1/8] drm/i915: Add a new PMU for handling non-OA counter data profiling requests sourab.gupta
2015-08-05 9:22 ` Chris Wilson
2015-08-05 9:40 ` Gupta, Sourab
2015-08-05 9:38 ` Chris Wilson
2015-08-05 9:45 ` Gupta, Sourab
2015-08-05 9:49 ` Gupta, Sourab
2015-08-05 11:08 ` Chris Wilson
2015-08-05 9:56 ` Chris Wilson
2015-08-05 5:55 ` [RFC 2/8] drm/i915: Add mechanism for forwarding the timestamp data through perf sourab.gupta
2015-08-05 9:55 ` Chris Wilson
2015-08-05 5:55 ` [RFC 3/8] drm/i915: Handle event stop and destroy for GPU commands submitted sourab.gupta
2015-08-05 5:55 ` [RFC 4/8] drm/i915: Insert commands for capturing timestamps in the ring sourab.gupta
2015-08-05 9:30 ` Chris Wilson
2015-08-05 9:54 ` Gupta, Sourab
2015-08-05 5:55 ` [RFC 5/8] drm/i915: Add support for forwarding ring id in sample metadata through perf sourab.gupta
2015-08-05 9:26 ` Chris Wilson
2015-08-05 5:55 ` [RFC 6/8] drm/i915: Add support for forwarding pid in timestamp " sourab.gupta
2015-08-05 5:55 ` [RFC 7/8] drm/i915: Add support for forwarding execbuffer tags in timestamp sample metadata sourab.gupta
2015-08-05 9:17 ` Chris Wilson
2015-08-05 9:29 ` Daniel Vetter [this message]
2015-08-05 13:59 ` Robert Bragg
2015-08-05 15:25 ` Daniel Vetter
2015-08-05 16:48 ` Robert Bragg
2015-08-05 5:55 ` [RFC 8/8] drm/i915: Support for retrieving MMIO register values alongwith timestamps through perf sourab.gupta
2015-08-05 10:03 ` Chris Wilson
2015-08-05 10:18 ` Gupta, Sourab
2015-08-05 10:30 ` Chris Wilson
2015-08-05 14:22 ` Gupta, Sourab
2015-08-05 20:19 ` Robert Bragg
-- strict thread matches above, loose matches on Subject: below --
2015-07-15 8:51 [RFC 0/8] Introduce framework for forwarding generic non-OA performance sourab.gupta
2015-07-15 8:51 ` [RFC 7/8] drm/i915: Add support for forwarding execbuffer tags in timestamp sample metadata sourab.gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805092938.GU17734@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=a.p.zijlstra@chello.nl \
--cc=chris@chris-wilson.co.uk \
--cc=insoo.woo@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jabin.wu@intel.com \
--cc=jon.bloomfield@intel.com \
--cc=robert@sixbynine.org \
--cc=sourab.gupta@intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox