Re: [PATCH 1/2 v2] drm/i915: Allow parsing of variable size child device entries from VBT

From: David Weinehall <david.weinehall@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2 v2] drm/i915: Allow parsing of variable size child device entries from VBT
Date: Wed, 5 Aug 2015 18:32:01 +0300	[thread overview]
Message-ID: <20150805153201.GD6150@boom> (raw)
In-Reply-To: <20150805085900.GM17734@phenom.ffwll.local>

On Wed, Aug 05, 2015 at 10:59:00AM +0200, Daniel Vetter wrote:
> On Tue, Aug 04, 2015 at 04:55:52PM +0300, David Weinehall wrote:
> > VBT version 196 increased the size of common_child_dev_config. The parser
> > code assumed that the size of this structure would not change.
> > 
> > The modified code now copies the amount needed based on the VBT version,
> > and emits a debug message if the VBT version is unknown (too new);
> > since the struct config block won't shrink in newer versions it should
> > be harmless to copy the maximum known size in such cases, so that's
> > what we do, but emitting the warning is probably sensible anyway.
> > 
> > In the longer run it might make sense to modify the parser code to
> > use a version/feature mapping, rather than hardcoding things like this,
> > but for now the variants are fairly managable.
> > 
> > v2: Stricter size checks
> > 
> > Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
> 
> Since Chris mentioned that this should fix a regression I applied it to
> drm-intel-fixes.

Great! Will you merge the other patch in the series to the nightly
build?

Regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx