From: Daniel Vetter <daniel@ffwll.ch>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Michel Thierry" <michel.thierry@intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
intel-gfx@lists.freedesktop.org,
"Mika Kuoppala" <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH v3] drm/i915/gtt: Avoid calling kcalloc in a loop when allocating temp bitmaps
Date: Wed, 2 Sep 2015 17:13:29 +0200 [thread overview]
Message-ID: <20150902151329.GL1367@phenom.ffwll.local> (raw)
In-Reply-To: <20150902134641.GC2808@nuc-i3427.alporthouse.com>
On Wed, Sep 02, 2015 at 02:46:41PM +0100, Chris Wilson wrote:
> On Wed, Sep 02, 2015 at 02:40:03PM +0100, Michel Thierry wrote:
> > On 9/1/2015 10:06 AM, Michał Winiarski wrote:
> > >On each call to gen8_alloc_va_range_3lvl we're allocating temporary
> > >bitmaps needed for error handling. Unfortunately, when we increase
> > >address space size (48b ppgtt) we do additional (512 - 4) calls to
> > >kcalloc, increasing latency between exec and actual start of execution
> > >on the GPU. Let's just do a single kcalloc, we can also drop the size
> > >from free_gen8_temp_bitmaps since it's no longer used.
> > >
> > >v2: Use GFP_TEMPORARY to make the allocations reclaimable.
> > >v3: Drop the 2D array, just allocate a single block.
> > >
> > >Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > >Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > >Cc: Michel Thierry <michel.thierry@intel.com>
> > >Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> >
> > Unless Chris thinks otherwise, I see Michał already addressed his comments.
>
> I think I spotted a misaligned bracket... ;)
checkpatch didn't spot it and neither me ...
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-02 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 16:27 [PATCH] drm/i915/gtt: Avoid calling kcalloc in a loop when allocating temp bitmaps Michał Winiarski
2015-08-31 16:40 ` Chris Wilson
2015-08-31 16:59 ` [PATCH v2] " Michał Winiarski
2015-08-31 18:42 ` Chris Wilson
2015-09-01 9:03 ` Michał Winiarski
2015-09-01 9:06 ` [PATCH v3] " Michał Winiarski
2015-09-02 13:40 ` Michel Thierry
2015-09-02 13:46 ` Chris Wilson
2015-09-02 15:13 ` Daniel Vetter [this message]
2015-09-02 15:26 ` Daniel Vetter
2015-09-02 15:46 ` [PATCH v4] " Michał Winiarski
2015-09-02 16:05 ` Chris Wilson
2015-09-03 17:22 ` [PATCH v5] " Michał Winiarski
2015-09-03 20:48 ` Chris Wilson
2015-09-04 7:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902151329.GL1367@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.winiarski@intel.com \
--cc=michel.thierry@intel.com \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox